[GitHub] [accumulo] ctubbsii commented on pull request #1799: Add getTabletState to TabletMetadata

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-732349773


   > This change is motivated by discussion on #1317 . I added this method to Ample to get the tablet state. The class where this is done is `TabletLocationState` and requires multiple column families (current, future, last and suspend), all having to do with tablet location. To make it easier to do this in Ample, I made the `ColumnType.LOCATION` fetch all four because it seemed confusing to fetch the famillies individually when they are all related.
   
   So, we're already fetching all four column families every time we need a location anyway? The code with the enums kinda seemed to be trying to match up with ensuring the fetching of their respective column families, but your changes removes that matching. It's probably better your way, but I recommend adding a comment to the ensureFetched method (or the enum) to make it clear that when that enum is used, *all* column families for the various locations are fetched.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org