You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/25 16:17:01 UTC

[GitHub] [pulsar] massakam opened a new pull request #11454: [stats] Do not expose meaningless stats for publisher

massakam opened a new pull request #11454:
URL: https://github.com/apache/pulsar/pull/11454


   ### Motivation
   
   Currently, publisher stats includes some fields that are meaningless for users.
   ```
   count
   producerNameOffset
   producerNameLength
   addressOffset
   addressLength
   connectedSinceOffset
   connectedSinceLength
   clientVersionOffset
   clientVersionLength
   stringBuffer
   ```
   These cause the size of the json data to grow and should not be exposed. 
   
   ### Modifications
   
   Add the `@JsonIgnore` annotation to the above fields. This is a modification similar to https://github.com/apache/pulsar/pull/11005.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #11454: [stats] Do not expose meaningless stats for publisher

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11454:
URL: https://github.com/apache/pulsar/pull/11454#issuecomment-887282156


   @massakam Thanks for your contribution. For this PR, do we need to update docs?
   
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] massakam commented on pull request #11454: [stats] Do not expose meaningless stats for publisher

Posted by GitBox <gi...@apache.org>.
massakam commented on pull request #11454:
URL: https://github.com/apache/pulsar/pull/11454#issuecomment-887287809


   @Anonymitaet Removed these fields from the json example in the documentation: https://github.com/apache/pulsar/pull/11454/commits/637b7aa9ece9fd3c92d5e8193211edc4a46a7271


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #11454: [stats] Do not expose meaningless stats for publisher

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11454:
URL: https://github.com/apache/pulsar/pull/11454


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org