You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/21 18:44:58 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3911: Implement ScalarValue for FixedSizeBinary

alamb commented on code in PR #3911:
URL: https://github.com/apache/arrow-datafusion/pull/3911#discussion_r1002088026


##########
datafusion/proto/src/to_proto.rs:
##########
@@ -1187,6 +1187,7 @@ impl TryFrom<&ScalarValue> for protobuf::ScalarValue {
                     Value::LargeBinaryValue(s.to_owned())
                 })
             }
+            scalar::ScalarValue::FixedSizeBinary(_, _) => todo!(),

Review Comment:
   Could you please return a "NotImplemented" error here rather than a `todo()` panic?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org