You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "linliu-code (via GitHub)" <gi...@apache.org> on 2025/10/01 22:56:36 UTC

[PR] fix: Flaky NPE during downgrade from Eight to Seven table version [hudi]

linliu-code opened a new pull request, #14029:
URL: https://github.com/apache/hudi/pull/14029

   ### Describe the issue this Pull Request addresses
   
   https://github.com/apache/hudi/issues/14028
   
   The test `TestUpgradeDowngrade.testUpgradeOrDowngrade` could throw NPE randomly.
   
   ### Summary and Changelog
   
   During the downgrade from eight to seven table version, 
   `ArchivedTimelineLoaderV2.loadInstants` invokes multi threads to load timeline instants, and stores them into a in-memory list using `ArchiveEntryFlusher.accept` function.
   
   However, there are two issues:
   1. `ArchiveEntryFlusher.accept` is not thread-safe.
   2. The in-memory list is not thread safe list. 
   
   Therefore, in some race conditions, the elements of the list could be cleared by one thread, while being flushed by another thread, which causes the NPE issue.
   
   Therefore, the fix is to make `ArchiveEntryFlusher.accept` and `ArchiveEntryFlusher.close` function thread safe.
   
   ### Impact
   
   1. Less flaky tests.
   2. Ensure the correctness and reliability of the downgrade process.
   
   ### Risk Level
   
   Medium.
   
   ### Documentation Update
   
   <!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
   
   - The config description must be updated if new configs are added or the default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: Flaky NPE during downgrade from Eight to Seven table version [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14029:
URL: https://github.com/apache/hudi/pull/14029#issuecomment-3358442270

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ef50218d774ccf60090f486da210e21d67e0d26c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9004",
       "triggerID" : "ef50218d774ccf60090f486da210e21d67e0d26c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ef50218d774ccf60090f486da210e21d67e0d26c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9004) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: Flaky NPE during downgrade from Eight to Seven table version [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #14029:
URL: https://github.com/apache/hudi/pull/14029


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: Flaky NPE during downgrade from Eight to Seven table version [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14029:
URL: https://github.com/apache/hudi/pull/14029#issuecomment-3358439188

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ef50218d774ccf60090f486da210e21d67e0d26c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ef50218d774ccf60090f486da210e21d67e0d26c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ef50218d774ccf60090f486da210e21d67e0d26c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: Flaky NPE during downgrade from Eight to Seven table version [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14029:
URL: https://github.com/apache/hudi/pull/14029#issuecomment-3358581605

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ef50218d774ccf60090f486da210e21d67e0d26c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9004",
       "triggerID" : "ef50218d774ccf60090f486da210e21d67e0d26c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ef50218d774ccf60090f486da210e21d67e0d26c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9004) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org