You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/04 10:29:41 UTC

[jira] [Commented] (BEAM-1862) SplittableDoFnOperator should close the ScheduledExecutorService

    [ https://issues.apache.org/jira/browse/BEAM-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954958#comment-15954958 ] 

ASF GitHub Bot commented on BEAM-1862:
--------------------------------------

GitHub user JingsongLi opened a pull request:

    https://github.com/apache/beam/pull/2421

    [BEAM-1862] SplittableDoFnOperator should close the ScheduledExecutor…

    …Service
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JingsongLi/beam BEAM-1862

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2421
    
----
commit 8c8a609e4e13830c2b5d6fc1a626d233ed442024
Author: JingsongLi <lz...@aliyun.com>
Date:   2017-04-04T10:28:15Z

    [BEAM-1862] SplittableDoFnOperator should close the ScheduledExecutorService

----


> SplittableDoFnOperator should close the ScheduledExecutorService
> ----------------------------------------------------------------
>
>                 Key: BEAM-1862
>                 URL: https://issues.apache.org/jira/browse/BEAM-1862
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Jingsong Lee
>            Assignee: Jingsong Lee
>
> {{SplittableDoFnOperator}} new a {{ScheduledExecutorService}} to {{OutputAndTimeBoundedSplittableProcessElementInvoker}}, but not shutdown it.
> We should shutdown it in {{close()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)