You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/07 01:55:02 UTC
[GitHub] [flink] JackWangCS opened a new pull request, #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode
JackWangCS opened a new pull request, #19666:
URL: https://github.com/apache/flink/pull/19666
## What is the purpose of the change
ZooKeeperUtils.deleteZNode implements a retry loop that is not necessary for curator version 4.0.1+. We can use idempotent delete since we already upgraded Curator to 5.2.0.
## Brief change log
- *Delete retry mechanism from ZooKeeperUtils.deleteZNode*
## Verifying this change
This change is already covered by existing tests, such as ZooKeeperUtilsWriteLeaderInformationTest#testDeleteZNode().
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19666:
URL: https://github.com/apache/flink/pull/19666#issuecomment-1120108334
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eeef4606a89d9137721fe4e43284167a76f911ed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eeef4606a89d9137721fe4e43284167a76f911ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eeef4606a89d9137721fe4e43284167a76f911ed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp merged pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode
Posted by GitBox <gi...@apache.org>.
XComp merged PR #19666:
URL: https://github.com/apache/flink/pull/19666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JackWangCS commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode
Posted by GitBox <gi...@apache.org>.
JackWangCS commented on PR #19666:
URL: https://github.com/apache/flink/pull/19666#issuecomment-1120109399
> @JackWangCS It looks good to me
Thank you for the code review, let us wait for the CI report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #19666:
URL: https://github.com/apache/flink/pull/19666#issuecomment-1131295085
...and rebased the branch. I will merge the change next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JackWangCS commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode
Posted by GitBox <gi...@apache.org>.
JackWangCS commented on PR #19666:
URL: https://github.com/apache/flink/pull/19666#issuecomment-1120108403
Hi @XComp , could you help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liuyongvs commented on pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on PR #19666:
URL: https://github.com/apache/flink/pull/19666#issuecomment-1120108825
@JackWangCS It looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org