You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/25 16:40:00 UTC
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage
abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627616#comment-16627616 ]
ASF GitHub Bot commented on ARTEMIS-2096:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2329
ARTEMIS-2096 Refactor AMQMessage abstraction
Major refactoring of the AMQPMessage abstraction to resolve
some issue of message corruption still present in the code and
improve the API handling of message changes and re-encoding.
Improves handling of decoding of message sections limiting the
work to only the portions needed and ensuring the state data
is always updated with what has been done. Fixes issues of
corrupt state on copy of message or other changes in filters.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-2096
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2329
----
commit ed7e7f206287db56f0c44c01fa2133c1fbd5c50d
Author: Timothy Bish <ta...@...>
Date: 2018-09-25T16:22:19Z
ARTEMIS-2096 Refactor AMQMessage abstraction
Major refactoring of the AMQPMessage abstraction to resolve
some issue of message corruption still present in the code and
improve the API handling of message changes and re-encoding.
Improves handling of decoding of message sections limiting the
work to only the portions needed and ensuring the state data
is always updated with what has been done. Fixes issues of
corrupt state on copy of message or other changes in filters.
----
> AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-2096
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2096
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.6.3
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Priority: Major
> Fix For: 2.7.0
>
>
> The AMQPMessage abstraction used to wrap the AMQP message section has some inconsistencies in how it manages the underlying data and the decoded AMQP section obtained from the Proton-J codec as well as issues with state being maintained in the presence of changes to the message made through the public facing Message APIs
> A refactoring of the AMQPMessage class to better utilize the proton-j codec to manage the message data and how it is parsed and re-encoded on change needs to be done to ensure no corrupt messages are sent and that we are not decoding and encoding sections of the message we are not intending to read or change on the sever (We currently can decode message bodies or footer is a few cases where we intend not to).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)