You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2018/11/22 08:42:56 UTC
[GitHub] hanabi1224 edited a comment on issue #29: Parameterless
LogManager.GetLogger
hanabi1224 edited a comment on issue #29: Parameterless LogManager.GetLogger
URL: https://github.com/apache/logging-log4net/pull/29#issuecomment-440953697
@dpsenner Thank you for your reply, that is good if it comes with a CA rule to warn if people copy that line across classes but forget to replace the type, because ideally every class has this static logger instance, it's common that people do the copy paste (especially during refactoring), and when these classes share namespaces, compiler won't even complain. Does that make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services