You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/18 20:27:39 UTC

[jira] [Commented] (WW-4590) Allow to use multiple names in result

    [ https://issues.apache.org/jira/browse/WW-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105716#comment-15105716 ] 

ASF GitHub Bot commented on WW-4590:
------------------------------------

GitHub user aleksandr-m opened a pull request:

    https://github.com/apache/struts/pull/75

    WW-4590 - Allow to use multiple names in result

    Allow to use multiple values in `result` tag `name` attribute and in `Result` annotation `name`.
    
    So this typical configuration:
    
    ```
    <action name="save">
        <result>success.jsp</result>
        <result name="error">input-form.jsp</result>
        <result name="input">input-form.jsp</result>
    </action>
    ```
    
    Can be shorten to that:
    
    ```
    <action name="save">
        <result>success.jsp</result>
        <result name="error, input">input-form.jsp</result>
    </action>
    ```
    
    And this annotations:
    
    ```
    @Action(results = {
        @Result(name="error", location="input-form.jsp"),
        @Result(name="input", location="input-form.jsp"),
        @Result(name="success", location="success.jsp")
    })
    ```
    
    To that:
    
    ```
    @Action(results = {
        @Result(name="error, input", location="input-form.jsp"),
        @Result(name="success", location="success.jsp")
    })
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aleksandr-m/struts feature/multiple_result_names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #75
    
----
commit 087cf610abcd262980a41c30a2f9360aa3f416e1
Author: Aleksandr Mashchenko <al...@gmail.com>
Date:   2016-01-18T19:23:46Z

    WW-4590 - Allow to use multiple names in result

----


> Allow to use multiple names in result
> -------------------------------------
>
>                 Key: WW-4590
>                 URL: https://issues.apache.org/jira/browse/WW-4590
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Convention, XML Configuration
>    Affects Versions: 2.3.24
>            Reporter: Aleksandr Mashchenko
>            Assignee: Aleksandr Mashchenko
>             Fix For: 2.5
>
>
> Allow to use multiple values in {{result}} tag {{name}} attribute and in {{Result}} annotation {{name}}.
> So this typical configuration:
> {code:xml}
> <action name="save">
>     <result>success.jsp</result>
>     <result name="error">input-form.jsp</result>
>     <result name="input">input-form.jsp</result>
> </action>
> {code}
> Can be shorten to that:
> {code:xml}
> <action name="save">
>     <result>success.jsp</result>
>     <result name="error, input">input-form.jsp</result>
> </action>
> {code}
> And this annotations:
> {code:java}
> @Action(results = {
>     @Result(name="error", location="input-form.jsp"),
>     @Result(name="input", location="input-form.jsp"),
>     @Result(name="success", location="success.jsp")
> })
> {code}
> To that:
> {code:java}
> @Action(results = {
>     @Result(name="error, input", location="input-form.jsp"),
>     @Result(name="success", location="success.jsp")
> })
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)