You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/24 13:58:41 UTC

[GitHub] [hudi] AirToSupply commented on a change in pull request #2986: [HUDI-1919] Type mismatch when streaming read copy_on_write table using flink

AirToSupply commented on a change in pull request #2986:
URL: https://github.com/apache/hudi/pull/2986#discussion_r637965360



##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java
##########
@@ -104,7 +106,7 @@ public static ParquetColumnarRowSplitReader genPartColumnarRowReader(
         .filter(nonPartNames::contains).collect(Collectors.toList());
 
     int[] selParquetFields = selNonPartNames.stream()
-        .mapToInt(nonPartNames::indexOf)
+        .mapToInt(fullNames::indexOf)
         .toArray();

Review comment:
       Grazie! I got it. If there are too many columns, use the indexOf or contains method to judge, the time complexity is O (n^2).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org