You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jaceklaskowski <gi...@git.apache.org> on 2016/03/11 19:35:03 UTC
[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55868740
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {
gzipHandlers.foreach(collection.addHandler)
connectors.foreach(_.setHost(hostName))
+ // As each acceptor and each selector will use one thread, the number of threads should at
+ // least be the number of acceptors and selectors plus 1. (See SPARK-13776)
+ var minThreads = 1
+ connectors.foreach { c =>
--- End diff --
Use `collect` or "cast" using pattern matching on type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org