You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/11 19:12:50 UTC
[GitHub] [solr] janhoy opened a new pull request, #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh
janhoy opened a new pull request, #1006:
URL: https://github.com/apache/solr/pull/1006
Needs export keyword...
https://issues.apache.org/jira/browse/SOLR-16406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1006:
URL: https://github.com/apache/solr/pull/1006#discussion_r969263259
##########
solr/bin/solr.in.sh:
##########
@@ -280,4 +280,4 @@
# SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true"
# The bundled plugins in the "modules" folder can easily be enabled as a comma-separated list in SOLR_MODULES variable
-# SOLR_MODULES=extraction,ltr
Review Comment:
Agree, it's safer to follow the beaten track of parsing the var in bin/solr. Closing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy closed pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh
Posted by GitBox <gi...@apache.org>.
janhoy closed pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh
URL: https://github.com/apache/solr/pull/1006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1006:
URL: https://github.com/apache/solr/pull/1006#discussion_r968435775
##########
solr/bin/solr.in.sh:
##########
@@ -280,4 +280,4 @@
# SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true"
# The bundled plugins in the "modules" folder can easily be enabled as a comma-separated list in SOLR_MODULES variable
-# SOLR_MODULES=extraction,ltr
Review Comment:
I think https://github.com/apache/solr/pull/1007 is a better approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1006:
URL: https://github.com/apache/solr/pull/1006#discussion_r967896147
##########
solr/bin/solr.in.sh:
##########
@@ -280,4 +280,4 @@
# SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true"
# The bundled plugins in the "modules" folder can easily be enabled as a comma-separated list in SOLR_MODULES variable
-# SOLR_MODULES=extraction,ltr
Review Comment:
The `bin/solr` script picks up `SOLR_OPTS` and other env.vars and pass them in as java sysprops on the cmdline.
With `SOLR_MODULES` the Java code (https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/util/ModuleUtils.java#L59:L71) parses both sys.prop and env.var. But it obviouly only works if the var is exported. It's a pity we need to touch the `bin/solr` and `bin/solr.cmd` scripts for every variable we want to add support for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1006:
URL: https://github.com/apache/solr/pull/1006#discussion_r967893619
##########
solr/bin/solr.in.sh:
##########
@@ -280,4 +280,4 @@
# SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true"
# The bundled plugins in the "modules" folder can easily be enabled as a comma-separated list in SOLR_MODULES variable
-# SOLR_MODULES=extraction,ltr
Review Comment:
Why is this one special compared to say SOLR_OPTS or others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thomaswoeckinger commented on a diff in pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh
Posted by GitBox <gi...@apache.org>.
thomaswoeckinger commented on code in PR #1006:
URL: https://github.com/apache/solr/pull/1006#discussion_r968305685
##########
solr/bin/solr.in.sh:
##########
@@ -280,4 +280,4 @@
# SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true"
# The bundled plugins in the "modules" folder can easily be enabled as a comma-separated list in SOLR_MODULES variable
-# SOLR_MODULES=extraction,ltr
Review Comment:
This change is also required in solr.in.cmd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org