You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Regis Xu (JIRA)" <ji...@apache.org> on 2007/07/26 05:10:31 UTC
[jira] Created: (HARMONY-4545) [classlib][sql][java6]
javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class) should not always
return null
[classlib][sql][java6] javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class<T>) should not always return null
---------------------------------------------------------------------------------------------------------
Key: HARMONY-4545
URL: https://issues.apache.org/jira/browse/HARMONY-4545
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Regis Xu
Below test case passed on ri but faild on harmony
public void test_unWrap_CClass() throws Exception {
Object o = metaDataImpl.unwrap(Integer.class);
assertNotNull(o);
assertTrue(o instanceof RowSetMetaDataImpl);
o = metaDataImpl.unwrap(Comparable.class);
assertNotNull(o);
assertTrue(o instanceof RowSetMetaDataImpl);
o = metaDataImpl.unwrap(null);
assertNotNull(o);
assertTrue(o instanceof RowSetMetaDataImpl);
}
so i think we should return a instance of RowSetMetaDataImpl instand of null value.
I will create a patch for this soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4545) [classlib][sql][java6]
javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class) should not always
return null
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu updated HARMONY-4545:
------------------------------
Patch Info: [Patch Available]
> [classlib][sql][java6] javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class<T>) should not always return null
> ---------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4545
> URL: https://issues.apache.org/jira/browse/HARMONY-4545
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Regis Xu
> Attachments: Harmony-4545.diff
>
>
> Below test case passed on ri but faild on harmony
> public void test_unWrap_CClass() throws Exception {
> Object o = metaDataImpl.unwrap(Integer.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(Comparable.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(null);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
> }
> so i think we should return a instance of RowSetMetaDataImpl instand of null value.
> I will create a patch for this soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4545) [classlib][sql][java6]
javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class) should not always
return null
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu closed HARMONY-4545.
-----------------------------
verified, thanks Tim
> [classlib][sql][java6] javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class<T>) should not always return null
> ---------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4545
> URL: https://issues.apache.org/jira/browse/HARMONY-4545
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Regis Xu
> Assignee: Tim Ellison
> Attachments: Harmony-4545.diff
>
>
> Below test case passed on ri but faild on harmony
> public void test_unWrap_CClass() throws Exception {
> Object o = metaDataImpl.unwrap(Integer.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(Comparable.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(null);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
> }
> so i think we should return a instance of RowSetMetaDataImpl instand of null value.
> I will create a patch for this soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4545) [classlib][sql][java6]
javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class) should not always
return null
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-4545.
----------------------------------
Resolution: Fixed
Thanks Regis,
Fixed in SQL module at repo revision r570840.
Please check it was fixed as you expected.
> [classlib][sql][java6] javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class<T>) should not always return null
> ---------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4545
> URL: https://issues.apache.org/jira/browse/HARMONY-4545
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Regis Xu
> Assignee: Tim Ellison
> Attachments: Harmony-4545.diff
>
>
> Below test case passed on ri but faild on harmony
> public void test_unWrap_CClass() throws Exception {
> Object o = metaDataImpl.unwrap(Integer.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(Comparable.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(null);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
> }
> so i think we should return a instance of RowSetMetaDataImpl instand of null value.
> I will create a patch for this soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4545) [classlib][sql][java6]
javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class) should not always
return null
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu updated HARMONY-4545:
------------------------------
Attachment: Harmony-4545.diff
May somebody pls try this patch? Thanks.
> [classlib][sql][java6] javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class<T>) should not always return null
> ---------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4545
> URL: https://issues.apache.org/jira/browse/HARMONY-4545
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Regis Xu
> Attachments: Harmony-4545.diff
>
>
> Below test case passed on ri but faild on harmony
> public void test_unWrap_CClass() throws Exception {
> Object o = metaDataImpl.unwrap(Integer.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(Comparable.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(null);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
> }
> so i think we should return a instance of RowSetMetaDataImpl instand of null value.
> I will create a patch for this soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4545) [classlib][sql][java6]
javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class) should not always
return null
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison reassigned HARMONY-4545:
------------------------------------
Assignee: Tim Ellison
> [classlib][sql][java6] javax.sql.rowset.RowSetMetaDataImpl#unWrap(Class<T>) should not always return null
> ---------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4545
> URL: https://issues.apache.org/jira/browse/HARMONY-4545
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Regis Xu
> Assignee: Tim Ellison
> Attachments: Harmony-4545.diff
>
>
> Below test case passed on ri but faild on harmony
> public void test_unWrap_CClass() throws Exception {
> Object o = metaDataImpl.unwrap(Integer.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(Comparable.class);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
>
> o = metaDataImpl.unwrap(null);
> assertNotNull(o);
> assertTrue(o instanceof RowSetMetaDataImpl);
> }
> so i think we should return a instance of RowSetMetaDataImpl instand of null value.
> I will create a patch for this soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.