You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/09 07:32:12 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
gaoyunhaii opened a new pull request #12053:
URL: https://github.com/apache/flink/pull/12053
## What is the purpose of the change
This PR adds listener into `Buckets` to support acquiring the events of state migration of `Bucket`. This is used to support writing meta-info in Hive Sink.
## Brief change log
- 1e1d15d10c7026928824e1fbc99099cc52821de4 Adds the bucket lifecycle listener.
## Verifying this change
This PR is verified by
- Added Unit test to verify the listener is called at suitable time if the listener is set.
- The existing tests verify the Buckets works well when the listener is not set.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f7cb8a717202562c9074e8b8bab636cf0a92994 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e1d15d10c7026928824e1fbc99099cc52821de4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e1d15d10c7026928824e1fbc99099cc52821de4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874)
* 9f7cb8a717202562c9074e8b8bab636cf0a92994 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e1d15d10c7026928824e1fbc99099cc52821de4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12053:
URL: https://github.com/apache/flink/pull/12053
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
}, {
"hash" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388",
"triggerID" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a96b05dc357929dd5e052e31d4d22f60803ed28 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r425489524
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -291,6 +291,7 @@ T withBucketFactory(final BucketFactory<IN, BucketID> factory) {
bucketFactory,
new RowWisePartWriter.Factory<>(encoder),
rollingPolicy,
+ null,
Review comment:
Also added as previous one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
}, {
"hash" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f7cb8a717202562c9074e8b8bab636cf0a92994 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219)
* 6a96b05dc357929dd5e052e31d4d22f60803ed28 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
}, {
"hash" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388",
"triggerID" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f7cb8a717202562c9074e8b8bab636cf0a92994 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219)
* 6a96b05dc357929dd5e052e31d4d22f60803ed28 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r422473420
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -401,6 +402,7 @@ public T withOutputFileConfig(final OutputFileConfig outputFileConfig) {
bucketFactory,
new BulkPartWriter.Factory<>(writerFactory),
rollingPolicy,
+ null,
Review comment:
Add litener setter to this bulk part writer builder?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -401,6 +402,7 @@ public T withOutputFileConfig(final OutputFileConfig outputFileConfig) {
bucketFactory,
new BulkPartWriter.Factory<>(writerFactory),
rollingPolicy,
+ null,
Review comment:
Add litsener setter to this bulk part writer builder?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r422473420
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -401,6 +402,7 @@ public T withOutputFileConfig(final OutputFileConfig outputFileConfig) {
bucketFactory,
new BulkPartWriter.Factory<>(writerFactory),
rollingPolicy,
+ null,
Review comment:
Add setter to this bulk part writer builder?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
}, {
"hash" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388",
"triggerID" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"triggerType" : "PUSH"
}, {
"hash" : "4d2d0e5c338e224c6d2247ab21a702e4d94536a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1438",
"triggerID" : "4d2d0e5c338e224c6d2247ab21a702e4d94536a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a96b05dc357929dd5e052e31d4d22f60803ed28 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388)
* 4d2d0e5c338e224c6d2247ab21a702e4d94536a5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1438)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
}, {
"hash" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388",
"triggerID" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"triggerType" : "PUSH"
}, {
"hash" : "4d2d0e5c338e224c6d2247ab21a702e4d94536a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1438",
"triggerID" : "4d2d0e5c338e224c6d2247ab21a702e4d94536a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d2d0e5c338e224c6d2247ab21a702e4d94536a5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1438)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r422473459
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -291,6 +291,7 @@ T withBucketFactory(final BucketFactory<IN, BucketID> factory) {
bucketFactory,
new RowWisePartWriter.Factory<>(encoder),
rollingPolicy,
+ null,
Review comment:
Add listener setter to this row wise part writer builder?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
##########
@@ -65,6 +65,9 @@
private final RollingPolicy<IN, BucketID> rollingPolicy;
+ @Nullable
+ private final BucketLifeCycleListener<IN, BucketID> bucketLifeCycleListener;
Review comment:
Should this be a `List<Listener>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1219",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
}, {
"hash" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388",
"triggerID" : "6a96b05dc357929dd5e052e31d4d22f60803ed28",
"triggerType" : "PUSH"
}, {
"hash" : "4d2d0e5c338e224c6d2247ab21a702e4d94536a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4d2d0e5c338e224c6d2247ab21a702e4d94536a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a96b05dc357929dd5e052e31d4d22f60803ed28 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1388)
* 4d2d0e5c338e224c6d2247ab21a702e4d94536a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e1d15d10c7026928824e1fbc99099cc52821de4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-628943586
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r424813284
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
##########
@@ -65,6 +65,9 @@
private final RollingPolicy<IN, BucketID> rollingPolicy;
+ @Nullable
+ private final BucketLifeCycleListener<IN, BucketID> bucketLifeCycleListener;
Review comment:
Do we need to supports more than one listeners currently ? I think we might postpone the support if it could support the current use cases. We should be able to keep compatibility with adding a new `withBucketLifeCycleListener(List<BucketLifeCycleListener> listeners>` to the format builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626122417
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1e1d15d10c7026928824e1fbc99099cc52821de4 (Sat May 09 07:34:32 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626125971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874",
"triggerID" : "1e1d15d10c7026928824e1fbc99099cc52821de4",
"triggerType" : "PUSH"
}, {
"hash" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9f7cb8a717202562c9074e8b8bab636cf0a92994",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e1d15d10c7026928824e1fbc99099cc52821de4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=874)
* 9f7cb8a717202562c9074e8b8bab636cf0a92994 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12053:
URL: https://github.com/apache/flink/pull/12053#issuecomment-626122417
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4d2d0e5c338e224c6d2247ab21a702e4d94536a5 (Fri Oct 16 10:31:12 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #12053: [FLINK-17590][connector/filesystem] Support bucket lifecycle listener in streaming file sink buckets
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r424811609
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
##########
@@ -401,6 +402,7 @@ public T withOutputFileConfig(final OutputFileConfig outputFileConfig) {
bucketFactory,
new BulkPartWriter.Factory<>(writerFactory),
rollingPolicy,
+ null,
Review comment:
Added the listener to the format builder to allow users to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org