You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aiguofer (via GitHub)" <gi...@apache.org> on 2023/06/21 15:33:13 UTC
[GitHub] [arrow-adbc] aiguofer opened a new pull request, #830: feat(python/adbc_driver_flightsql) Add cookie middleware option to DatabaseOptions
aiguofer opened a new pull request, #830:
URL: https://github.com/apache/arrow-adbc/pull/830
Add new cookie middleware option (#825) to python constants. Also see #716.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #830: feat(python/adbc_driver_flightsql): add cookie middleware option to DatabaseOptions
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #830:
URL: https://github.com/apache/arrow-adbc/pull/830#issuecomment-1601320910
Ah, I'll fix the Windows error separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #830: feat(python/adbc_driver_flightsql): add cookie middleware option to DatabaseOptions
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #830:
URL: https://github.com/apache/arrow-adbc/pull/830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #830: feat(python/adbc_driver_flightsql): add cookie middleware option to DatabaseOptions
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #830:
URL: https://github.com/apache/arrow-adbc/pull/830#discussion_r1237218768
##########
python/adbc_driver_flightsql/adbc_driver_flightsql/__init__.py:
##########
@@ -70,6 +70,8 @@ class DatabaseOptions(enum.Enum):
WITH_BLOCK = "adbc.flight.sql.client_option.with_block"
#: Set the maximum gRPC message size (in bytes). The default is 16 MiB.
WITH_MAX_MSG_SIZE = "adbc.flight.sql.client_option.with_max_msg_size"
+ #: Enable cookie middleware. Default is disabled ("false")
+ WITH_COOKIE_MIDDLEWARE = "adbc.flight.sql.rpc.with_cookie_middleware"
Review Comment:
Can we keep the options alphabetized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] github-actions[bot] commented on pull request #830: feat(python/adbc_driver_flightsql) Add cookie middleware option to DatabaseOptions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #830:
URL: https://github.com/apache/arrow-adbc/pull/830#issuecomment-1601072266
:warning: Please follow the [Conventional Commits format in CONTRIBUTING.md](https://github.com/apache/arrow-adbc/blob/main/CONTRIBUTING.md) for PR titles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #830: feat(python/adbc_driver_flightsql): add cookie middleware option to DatabaseOptions
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #830:
URL: https://github.com/apache/arrow-adbc/pull/830#issuecomment-1601172860
Let me kick CI first...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] aiguofer commented on a diff in pull request #830: feat(python/adbc_driver_flightsql): add cookie middleware option to DatabaseOptions
Posted by "aiguofer (via GitHub)" <gi...@apache.org>.
aiguofer commented on code in PR #830:
URL: https://github.com/apache/arrow-adbc/pull/830#discussion_r1237274301
##########
python/adbc_driver_flightsql/adbc_driver_flightsql/__init__.py:
##########
@@ -70,6 +70,8 @@ class DatabaseOptions(enum.Enum):
WITH_BLOCK = "adbc.flight.sql.client_option.with_block"
#: Set the maximum gRPC message size (in bytes). The default is 16 MiB.
WITH_MAX_MSG_SIZE = "adbc.flight.sql.client_option.with_max_msg_size"
+ #: Enable cookie middleware. Default is disabled ("false")
+ WITH_COOKIE_MIDDLEWARE = "adbc.flight.sql.rpc.with_cookie_middleware"
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org