You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/06/29 04:15:23 UTC
[GitHub] flink pull request #4217: [FLINK-6934] [util] remove unused LRUCache class
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4217
[FLINK-6934] [util] remove unused LRUCache class
Remove unused ```LRUCache``` class since it was created in 2014.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6934
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4217
----
commit a4884c3f7bf0564dc2469c1609e57798d646d503
Author: zhangminglei <zm...@163.com>
Date: 2017-06-29T04:13:22Z
[FLINK-6934] [util] remove unused LRUCache class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4217: [FLINK-6934] [util] remove unused LRUCache class
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4217
Hello, @aljoscha PR had been updated. Please helps check it again, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4217: [FLINK-6934] [util] remove unused LRUCache class
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4217
Sure, Thanks, I had seen those before. ```LRUCacheMap``` and ```LRUCacheMapTest``` will be removed in this PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4217: [FLINK-6934] [util] remove unused LRUCache class
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/4217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4217: [FLINK-6934] [util] remove unused LRUCache class
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4217
Thanks for working on this! While on it, could you also remove `LRUCacheMap` and `LRUCacheMapTest`? I think these are similarly unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4217: [FLINK-6934] [util] remove unused LRUCache class
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4217
Yep. I will close this PR. 咯咯~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4217: [FLINK-6934] [util] remove unused LRUCache class
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4217
Thanks! I merged 😃
Could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---