You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "George Fletcher (Created) (JIRA)" <ji...@apache.org> on 2011/11/28 21:31:40 UTC
[jira] [Created] (AVRO-963) Allow
Allow
------
Key: AVRO-963
URL: https://issues.apache.org/jira/browse/AVRO-963
Project: Avro
Issue Type: Improvement
Components: java
Affects Versions: 1.6.1
Reporter: George Fletcher
Priority: Minor
It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-963) Allow
Posted by "George Fletcher (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158741#comment-13158741 ]
George Fletcher commented on AVRO-963:
--------------------------------------
It's pretty straight forward to leverage the SpecificCompiler.java setTemplateDir() method via a configuration parameter. However, this still requires the templates to be part of the java class path. Is that acceptable?
For example in the *Mojo.java files...
{code}
/**
*
* Override the default location for the velocity templates
* @parameter
*/
private String templateDir = null;
@Override
protected void doCompile (...) {
...
SpecificCompiler compiler = new SpecificCompiler(protocol);
if (this.templateDir != null) {
compiler.setTemplateDir(this.templateDir);
}
compiler.setStringType(StringType.valueOf(stringType));
compiler.compileToDestination(src, outputDirectory);
...
}
{code}
> Allow
> ------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Priority: Minor
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-963) Allow compiler's template directory to
be overridden in Maven plugins
Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-963:
------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed this. Thanks, George!
> Allow compiler's template directory to be overridden in Maven plugins
> ---------------------------------------------------------------------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Assignee: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-963) Allow compiler's template directory to
be overridden in Maven plugins
Posted by "Ed Kohlwey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ed Kohlwey updated AVRO-963:
----------------------------
Attachment: AVRO-1094.patch.2
Here's a better patch with a test included.
> Allow compiler's template directory to be overridden in Maven plugins
> ---------------------------------------------------------------------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Assignee: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-963) Allow
Posted by "George Fletcher (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Fletcher updated AVRO-963:
---------------------------------
Attachment: avro-jira-963.patch
> Allow
> ------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-963) Allow compiler's template directory
to be overridden in Maven plugins
Posted by "Ed Kohlwey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277958#comment-13277958 ]
Ed Kohlwey commented on AVRO-963:
---------------------------------
*edit- just to clarify, I'm putting the templates in ${project.basedir}/src/main/resources/...
> Allow compiler's template directory to be overridden in Maven plugins
> ---------------------------------------------------------------------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Assignee: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-963) Allow compiler's template directory to
be overridden in Maven plugins
Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-963:
------------------------------
Assignee: George Fletcher
Summary: Allow compiler's template directory to be overridden in Maven plugins (was: Allow )
> Allow compiler's template directory to be overridden in Maven plugins
> ---------------------------------------------------------------------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Assignee: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-963) Allow compiler's template directory
to be overridden in Maven plugins
Posted by "Ed Kohlwey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277944#comment-13277944 ]
Ed Kohlwey commented on AVRO-963:
---------------------------------
Has anyone tried this? Putting the velocity templates in /src/resources/... doesn't seem to actually get them on the *plugin* classpath. Or perhaps I'm doing something wrong...
> Allow compiler's template directory to be overridden in Maven plugins
> ---------------------------------------------------------------------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Assignee: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-963) Allow
Posted by "George Fletcher (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Fletcher updated AVRO-963:
---------------------------------
Fix Version/s: 1.6.2
Status: Patch Available (was: Open)
Added a 'templateDirectory' configuration parameter for the avro-maven-plugin that allows the default template directory to be overridden.
> Allow
> ------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-963) Allow compiler's template directory
to be overridden in Maven plugins
Posted by "Scott Carey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168662#comment-13168662 ]
Scott Carey commented on AVRO-963:
----------------------------------
This is great! I'll be using it soon.
> Allow compiler's template directory to be overridden in Maven plugins
> ---------------------------------------------------------------------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Assignee: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-963) Allow compiler's template directory to
be overridden in Maven plugins
Posted by "Ed Kohlwey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ed Kohlwey updated AVRO-963:
----------------------------
Attachment: (was: AVRO-1094.patch.2)
> Allow compiler's template directory to be overridden in Maven plugins
> ---------------------------------------------------------------------
>
> Key: AVRO-963
> URL: https://issues.apache.org/jira/browse/AVRO-963
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.6.1
> Reporter: George Fletcher
> Assignee: George Fletcher
> Priority: Minor
> Fix For: 1.6.2
>
> Attachments: avro-jira-963.patch
>
>
> It is currently not possible to override the location of the velocity templates except via overriding a system property which requires a maven command line option. Allow for the location of the templates to be specified via a configuration parameter in the avro maven plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira