[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1018: [MNG-7713] Drop legacy-local-repository option

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on code in PR #1018:
URL: https://github.com/apache/maven/pull/1018#discussion_r1120679215


##########
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##########
@@ -256,8 +256,7 @@ public CLIManager() {
                 .build());
         options.addOption(Option.builder(LEGACY_LOCAL_REPOSITORY)
                 .longOpt("legacy-local-repository")
-                .desc(
-                        "Use Maven 2 Legacy Local Repository behaviour, ie no use of _remote.repositories. Can also be activated by using -Dmaven.legacyLocalRepo=true")
+                .desc("Ineffective, only kept for backward compatibility.")

Review Comment:
   If such option will have  no effect - why we want to preserve it ... 
   If user use it - it will not works as user expect - so we will have silently different behavior that user think
   
   For me will be better to drop at all -  it will more clear for user and do not make confusing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org