You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/05/25 10:50:02 UTC

Review Request 67317: Fixed flaky `TerminatedNestedStatus` test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67317/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.


Repository: mesos


Description
-------

This patch adds call of `destroy()` for a parent container.


Diffs
-----

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp dac30d7643ba5b053d16439411ef1114b02a4fdd 


Diff: https://reviews.apache.org/r/67317/diff/1/


Testing
-------

sudo ./src/mesos-tests --gtest_filter=NestedMesosContainerizerTest.ROOT_CGROUPS_TerminatedNestedStatus --gtest_break_on_failure --gtest_repeat=100


Thanks,

Andrei Budnik

Re: Review Request 67317: Fixed flaky `TerminatedNestedStatus` test.

Posted by Qian Zhang <zh...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67317/#review203873
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On May 25, 2018, 6:50 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67317/
> -----------------------------------------------------------
> 
> (Updated May 25, 2018, 6:50 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds call of `destroy()` for a parent container.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp dac30d7643ba5b053d16439411ef1114b02a4fdd 
> 
> 
> Diff: https://reviews.apache.org/r/67317/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ./src/mesos-tests --gtest_filter=NestedMesosContainerizerTest.ROOT_CGROUPS_TerminatedNestedStatus --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>