You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/01/30 06:30:02 UTC

Re: [PR] [fix][client] Fix ConsumerBuilderImpl#subscribe silent stuck when using pulsar-client:3.0.x with jackson-annotations prior to 2.12.0 [pulsar]

lhotari commented on PR #21985:
URL: https://github.com/apache/pulsar/pull/21985#issuecomment-1916164126

   > Modify the `whenComplete` to a combination of `thenAccept` and `exceptionally`. The modification is harmless.
   
   I finally understood what the difference is. In this case, it matters since there's a separate CompletableFuture `subscribeResult` which is the actual result. If the handler of whenComplete itself throws an exception, the `subscribeResult` didn't get completed with the exception. The fix will address that. 
   Good catch @Shawyeok! Thanks for fixing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org