You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/08 14:19:50 UTC

[GitHub] uce opened a new pull request #7670: [FLINK-11544] Add jobId to JarRequestBody

uce opened a new pull request #7670: [FLINK-11544] Add jobId to JarRequestBody
URL: https://github.com/apache/flink/pull/7670
 
 
   ## What is the purpose of the change
   
   - This PR adds the optional `jobId` entry to `JarRequestBody`
     * If specified, users manually set the job ID of a job when submitting a JAr
     * If not specified, we keep the current behavior
   
   ## Brief change log
   
   - Add `jobId` to `JarRequestBody`
   - Parse `jobId` when generating `JobGraph`
   
   ## Verifying this change
   
   - This change added unit tests for added functionality
   - If you want to manually verify this change, you can follow these steps:
     1. Build this branch
     2. Upload `examples/streaming/TopSpeedWindowing.jar` via web UI
     3. Get `$jarId` from `/v1/jars` endpoint
     4. Execute `curl -X POST -d '{}' http://localhost:8081/v1/jars/$jarId/run` (expected: random job ID)
     5. Execute `curl -X POST -d '{"jobId": "4\. fd72014d4c864993a2e5a9287b4a9c5d"}' http://localhost:8081/v1/jars/$jarId/run` (expected: job ID `fd72014d4c864993a2e5a9287b4a9c5d`)
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes (adds new field in request body of a v1 REST API endpoint)
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: no
     - The S3 file system connector: no
   
   ## Documentation
   
   - I didn't add any documentation as I assume that the REST API docs are auto generated (@zentol please correct me if I'm wrong)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services