You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2008/05/07 22:14:48 UTC

[Bug 5901] New: typo in regexp within 20_vbounce.cf

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5901

           Summary: typo in regexp within 20_vbounce.cf
           Product: Spamassassin
           Version: 3.2.4
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Rules
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: rmueller@thinxsolutions.com


I observed the vbounce rule not recognizing many bounces originated by UBE with
faked sender addresses. 
After digging into this, it showed that the body-rule " __HAVE_BOUNCE_RELAYS"
is giving a "1", but often no header rule "__BOUNCE*" seems to give a hit. One
of the most likely rules to be IMHO true is the "__BOUNCE_FROM_DAEMON" one, but
this one nearly never gives a hit for me. 
Within the rules file "20_vbounce.cf", the regexp in the "__BOUNCE_FROM_DAEMON"
line seems not to be correct from my point of view. Instead of the "+" after
the \S I would expect a "*", as it is in the similar regexp of
"__BOUNCE_RPATH_MD".
So for testing purposes I modified the line

old:
header __BOUNCE_FROM_DAEMON   From =~ 
/(?:(?:daemon|deamon|majordomo|postmaster|virus|scanner|devnull|automated-response|SMTP.gateway|mailadmin|mailmaster|surfcontrol|You_Got_Spammed)\S+\@|<>)/i

to new:
header __BOUNCE_FROM_DAEMON   From =~ 
/(?:(?:daemon|deamon|majordomo|postmaster|virus|scanner|devnull|automated-response|SMTP.gateway|mailadmin|mailmaster|surfcontrol|You_Got_Spammed)\S*\@|<>)/i

and then also the bounces formerly not recognized are correctly identified.

Justin Mason confirmed this in the users mailing list.


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5901] need * instead of + within 20_vbounce.cf

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5901


Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|typo in regexp within       |need * instead of + within
                   |20_vbounce.cf               |20_vbounce.cf
   Target Milestone|Undefined                   |3.2.5




-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 5901] need * instead of + within 20_vbounce.cf

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5901


Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Justin Mason <jm...@jmason.org>  2008-05-21 09:32:14 PST ---
applied to 3.2.x maintainance branch:

: jm 61...; svn commit -m "trivial bugfix: __BOUNCE_FROM_DAEMON incorrectly
used + instead of *, so some From addresses were not being recognised as bounce
senders" rules/20_vbounce.cf
Sending        rules/20_vbounce.cf
Transmitting file data .
Committed revision 658745.

and in updates:

: jm 63...; svn commit -m "trivial bugfix: __BOUNCE_FROM_DAEMON incorrectly
used + instead of *, so some From addresses were not being recognised as bounce
senders" ../b3_2_0_updates/20_vbounce.cf
Sending        b3_2_0_updates/20_vbounce.cf
Transmitting file data .
Committed revision 658747.

(although I haven't pushed that yet)


-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.