You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/10/26 07:01:50 UTC
Review Request 63322: Added placeholder handlers and other changes for
operation updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63322/
-----------------------------------------------------------
Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone.
Bugs: MESOS-8130
https://issues.apache.org/jira/browse/MESOS-8130
Repository: mesos
Description
-------
This patch adds empty placeholder handler functions which will
be used for offer operation status updates as well as their
acknowledgement and reconciliation.
A number of switch statements are also updated to handle new
enum values and validation code is added.
Diffs
-----
src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853
src/examples/long_lived_framework.cpp adfe10eca2af26e8294171256e5f053fb46abf24
src/examples/test_http_framework.cpp e640800055bd9a946663de377970e867d29c750a
src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043
src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
src/master/validation.cpp 42f5742386b59a983f7caaf3400c82b7ef4f8bbb
src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de
src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954
Diff: https://reviews.apache.org/r/63322/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 63322: Added placeholder handlers and other
changes for operation updates.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63322/#review189277
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.hpp
Lines 1005 (patched)
<https://reviews.apache.org/r/63322/#comment266289>
Ditto on naming. `acknowledgeOfferOperationStatusUpdate`
src/slave/slave.hpp
Lines 285 (patched)
<https://reviews.apache.org/r/63322/#comment266292>
`offerOperationStatusUpdateAcknowledgement`
- Jie Yu
On Oct. 26, 2017, 7:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63322/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 7:01 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8130
> https://issues.apache.org/jira/browse/MESOS-8130
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds empty placeholder handler functions which will
> be used for offer operation status updates as well as their
> acknowledgement and reconciliation.
>
> A number of switch statements are also updated to handle new
> enum values and validation code is added.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853
> src/examples/long_lived_framework.cpp adfe10eca2af26e8294171256e5f053fb46abf24
> src/examples/test_http_framework.cpp e640800055bd9a946663de377970e867d29c750a
> src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
> src/master/validation.cpp 42f5742386b59a983f7caaf3400c82b7ef4f8bbb
> src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de
> src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
> src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
> src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954
>
>
> Diff: https://reviews.apache.org/r/63322/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63322: Added placeholder handlers and other
changes for operation updates.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63322/#review189325
-----------------------------------------------------------
PASS: Mesos patch 63322 was successfully built and tested.
Reviews applied: `['63001', '62903', '63094', '63321', '63322']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63322
- Mesos Reviewbot Windows
On Oct. 26, 2017, 7:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63322/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 7:01 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8130
> https://issues.apache.org/jira/browse/MESOS-8130
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds empty placeholder handler functions which will
> be used for offer operation status updates as well as their
> acknowledgement and reconciliation.
>
> A number of switch statements are also updated to handle new
> enum values and validation code is added.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853
> src/examples/long_lived_framework.cpp adfe10eca2af26e8294171256e5f053fb46abf24
> src/examples/test_http_framework.cpp e640800055bd9a946663de377970e867d29c750a
> src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
> src/master/validation.cpp 42f5742386b59a983f7caaf3400c82b7ef4f8bbb
> src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de
> src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
> src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
> src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954
>
>
> Diff: https://reviews.apache.org/r/63322/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63322: Added placeholder handlers and other
changes for operation updates.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63322/#review189549
-----------------------------------------------------------
PASS: Mesos patch 63322 was successfully built and tested.
Reviews applied: `['63321', '63322']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63322
- Mesos Reviewbot Windows
On Oct. 30, 2017, 7:16 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63322/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 7:16 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8130
> https://issues.apache.org/jira/browse/MESOS-8130
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds empty placeholder handler functions which will
> be used for offer operation status updates as well as their
> acknowledgement and reconciliation.
>
> A number of switch statements are also updated to handle new
> enum values and validation code is added.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853
> src/examples/long_lived_framework.cpp adfe10eca2af26e8294171256e5f053fb46abf24
> src/examples/test_http_framework.cpp e640800055bd9a946663de377970e867d29c750a
> src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 0e7716d489556ef58313cb5f95c39234aea82f11
> src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
> src/master/validation.cpp 42f5742386b59a983f7caaf3400c82b7ef4f8bbb
> src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de
> src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
> src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
> src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954
>
>
> Diff: https://reviews.apache.org/r/63322/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63322: Added placeholder handlers and other
changes for operation updates.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63322/#review189628
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63001, 62903, 63094, 63321, 63322]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 30, 2017, 5:04 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63322/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 5:04 p.m.)
>
>
> Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8130
> https://issues.apache.org/jira/browse/MESOS-8130
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds empty placeholder handler functions which will
> be used for offer operation status updates as well as their
> acknowledgement and reconciliation.
>
> A number of switch statements are also updated to handle new
> enum values and validation code is added.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853
> src/examples/long_lived_framework.cpp adfe10eca2af26e8294171256e5f053fb46abf24
> src/examples/test_http_framework.cpp e640800055bd9a946663de377970e867d29c750a
> src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 0e7716d489556ef58313cb5f95c39234aea82f11
> src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043
> src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3
> src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28
> src/master/validation.cpp d6d6f21b4cb2146d04e03b722f71230b6f0f600e
> src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de
> src/slave/slave.hpp 1b7f61671a1cf8f516d28c3bda516478f1213594
> src/slave/slave.cpp 817dca4fc3e1028ccc13b8a1bb1ee783afb77166
> src/tests/mesos.hpp 615e4ce19b51bb7284feef8edf6fd2b1753c9bb0
>
>
> Diff: https://reviews.apache.org/r/63322/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63322: Added placeholder handlers and other
changes for operation updates.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63322/
-----------------------------------------------------------
(Updated Oct. 30, 2017, 5:04 p.m.)
Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone.
Bugs: MESOS-8130
https://issues.apache.org/jira/browse/MESOS-8130
Repository: mesos
Description
-------
This patch adds empty placeholder handler functions which will
be used for offer operation status updates as well as their
acknowledgement and reconciliation.
A number of switch statements are also updated to handle new
enum values and validation code is added.
Diffs (updated)
-----
src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853
src/examples/long_lived_framework.cpp adfe10eca2af26e8294171256e5f053fb46abf24
src/examples/test_http_framework.cpp e640800055bd9a946663de377970e867d29c750a
src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 0e7716d489556ef58313cb5f95c39234aea82f11
src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043
src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3
src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28
src/master/validation.cpp d6d6f21b4cb2146d04e03b722f71230b6f0f600e
src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de
src/slave/slave.hpp 1b7f61671a1cf8f516d28c3bda516478f1213594
src/slave/slave.cpp 817dca4fc3e1028ccc13b8a1bb1ee783afb77166
src/tests/mesos.hpp 615e4ce19b51bb7284feef8edf6fd2b1753c9bb0
Diff: https://reviews.apache.org/r/63322/diff/3/
Changes: https://reviews.apache.org/r/63322/diff/2-3/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 63322: Added placeholder handlers and other
changes for operation updates.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63322/#review189548
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63001, 62903, 63094, 63321, 63322]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 30, 2017, 2:16 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63322/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 2:16 p.m.)
>
>
> Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8130
> https://issues.apache.org/jira/browse/MESOS-8130
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds empty placeholder handler functions which will
> be used for offer operation status updates as well as their
> acknowledgement and reconciliation.
>
> A number of switch statements are also updated to handle new
> enum values and validation code is added.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853
> src/examples/long_lived_framework.cpp adfe10eca2af26e8294171256e5f053fb46abf24
> src/examples/test_http_framework.cpp e640800055bd9a946663de377970e867d29c750a
> src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 0e7716d489556ef58313cb5f95c39234aea82f11
> src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
> src/master/validation.cpp 42f5742386b59a983f7caaf3400c82b7ef4f8bbb
> src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de
> src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
> src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
> src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954
>
>
> Diff: https://reviews.apache.org/r/63322/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 63322: Added placeholder handlers and other
changes for operation updates.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63322/
-----------------------------------------------------------
(Updated Oct. 30, 2017, 6:16 a.m.)
Review request for mesos, Gaston Kleiman, Jie Yu, and Vinod Kone.
Bugs: MESOS-8130
https://issues.apache.org/jira/browse/MESOS-8130
Repository: mesos
Description
-------
This patch adds empty placeholder handler functions which will
be used for offer operation status updates as well as their
acknowledgement and reconciliation.
A number of switch statements are also updated to handle new
enum values and validation code is added.
Diffs (updated)
-----
src/cli/execute.cpp f5d4bc5da26f232a1fad1169b0c656b19132b853
src/examples/long_lived_framework.cpp adfe10eca2af26e8294171256e5f053fb46abf24
src/examples/test_http_framework.cpp e640800055bd9a946663de377970e867d29c750a
src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 0e7716d489556ef58313cb5f95c39234aea82f11
src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043
src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
src/master/validation.cpp 42f5742386b59a983f7caaf3400c82b7ef4f8bbb
src/sched/sched.cpp fb77b79a05d5db21c8642cb8915e9bdcc1e2b1de
src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954
Diff: https://reviews.apache.org/r/63322/diff/2/
Changes: https://reviews.apache.org/r/63322/diff/1-2/
Testing
-------
`make check`
Thanks,
Greg Mann