You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2016/12/27 11:17:23 UTC

Review Request 55047: Wrong number of filtered hosts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55047/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-19299
    https://issues.apache.org/jira/browse/AMBARI-19299


Repository: ambari


Description
-------

For example, in the sequence of attached screen captures which have filenames corresponding to the time stamps, you can see:
1) Screen Shot 2016-08-12 at 5.30.42 PM - filtering the 445 nodes that need a restart. 
2) Screen Shot 2016-08-12 at 5.30.55 PM - first 10 filtered nodes show, but only "1 - 10 of 10" showing in the bottom right corner, and right arrow is grey. 
3) Screen Shot 2016-08-12 at 5.31.02 PM - same as preceding screenshot. 
4) Screen Shot 2016-08-12 at 5.31.13 PM - Suddenly and only for less than a second, "1 - 10 of 445" is displayed and the right arrow is blue.
The problem can be replicated consistently across browsers.


Diffs
-----

  ambari-web/app/controllers/global/update_controller.js a3aee37 
  ambari-web/app/controllers/main/host.js b85ed95 
  ambari-web/app/utils/http_client.js dbfc640 

Diff: https://reviews.apache.org/r/55047/diff/


Testing
-------

19829 passing (25s)
  153 pending


Thanks,

Andrii Tkach


Re: Review Request 55047: Wrong number of filtered hosts

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55047/#review160146
-----------------------------------------------------------


Ship it!




Ship It!

- Oleg Nechiporenko


On Dec. 27, 2016, 11:17 a.m., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55047/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2016, 11:17 a.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-19299
>     https://issues.apache.org/jira/browse/AMBARI-19299
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For example, in the sequence of attached screen captures which have filenames corresponding to the time stamps, you can see:
> 1) Screen Shot 2016-08-12 at 5.30.42 PM - filtering the 445 nodes that need a restart. 
> 2) Screen Shot 2016-08-12 at 5.30.55 PM - first 10 filtered nodes show, but only "1 - 10 of 10" showing in the bottom right corner, and right arrow is grey. 
> 3) Screen Shot 2016-08-12 at 5.31.02 PM - same as preceding screenshot. 
> 4) Screen Shot 2016-08-12 at 5.31.13 PM - Suddenly and only for less than a second, "1 - 10 of 445" is displayed and the right arrow is blue.
> The problem can be replicated consistently across browsers.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/global/update_controller.js a3aee37 
>   ambari-web/app/controllers/main/host.js b85ed95 
>   ambari-web/app/utils/http_client.js dbfc640 
> 
> Diff: https://reviews.apache.org/r/55047/diff/
> 
> 
> Testing
> -------
> 
> 19829 passing (25s)
>   153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>