[GitHub] [airflow] edithturn edited a comment on pull request #22327: Rewrite Selective Check in Python

[GitBox <gi...@apache.org>]

edithturn edited a comment on pull request #22327:
URL: https://github.com/apache/airflow/pull/22327#issuecomment-1072915862


   @potiuk  I created two different files:  scc_get_changed_files.py and selective_ci_checks.py and in ci.yaml I am just calling to selective_ci_checks.py.
   I have a doubt about this statement:
   ![Screenshot from 2022-03-18 20-21-44](https://user-images.githubusercontent.com/58795858/159101782-83e73a36-1b33-4b22-9eae-a751827c31f4.png)
   I understand this: 
   1. Direct Push (PR is **merged**) doesn't generate a commit hash (SHA)
   2. **Merge** Commit generates a commit hash
   
   Both are "merged" why **Direct Push** doesn't generate a commit SHA?
   
   On the other hand, could you explain to me the selected part of this script?
   I know that we are trying to get all the names of the changed files from a commit SHA. I saw also that this symbol "^" in bash is to keep lower case the first letter of a string (In python I am having the same issue "ambiguous argument")
   https://github.com/apache/airflow/blob/0ec56775df66063cab807d886e412ebf88c572bf/scripts/ci/selective_ci_checks.sh#L154-L155
   ![Screenshot from 2022-03-18 20-44-27](https://user-images.githubusercontent.com/58795858/159102205-ed4274a1-bdec-422f-978e-1f5cd3a11317.png)
   
   Thanks in advance!
   
   This is a great task, I am getting fun 💃🏼 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org