[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2669: [GOBBLIN-803] HivePartition record count

[GitBox <gi...@apache.org>]

jhsenjaliya commented on a change in pull request #2669: [GOBBLIN-803] HivePartition record count
URL: https://github.com/apache/incubator-gobblin/pull/2669#discussion_r296466200
 
 

 ##########
 File path: gobblin-core/src/main/java/org/apache/gobblin/publisher/HiveRegistrationPublisher.java
 ##########
 @@ -189,9 +200,27 @@ public void publishMetadata(Collection<? extends WorkUnitState> states) throws I
     // Nothing to do
   }
 
-  private static void addRuntimeHiveRegistrationProperties(State state) {
-    // Use seconds instead of milliseconds to be consistent with other times stored in hive
-    state.appendToListProp(HiveRegProps.HIVE_TABLE_PARTITION_PROPS,
-        String.format("%s:%d", DATA_PUBLISH_TIME, TimeUnit.SECONDS.convert(System.currentTimeMillis(), TimeUnit.MILLISECONDS)));
+  /**
+   * A wrapper for updating partition record count to {@link #pathToRecordCount}.
+   */
+  private void countUpForPath(String path, State state) {
 
 Review comment:
   this function name says count, but its just getting the record count from the state, is plan to actually count the records in future? otherwise it should be renamed as getRecordCountsFromState or getRecordCounts or something.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services