[GitHub] [madlib] njayaram2 commented on a change in pull request #371: DL: Add Postgres support

[GitBox <gi...@apache.org>]

njayaram2 commented on a change in pull request #371: DL: Add Postgres support
URL: https://github.com/apache/madlib/pull/371#discussion_r277461370
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
 ##########
 @@ -102,39 +103,48 @@ def fit(schema_madlib, source_table, model, dependent_varname,
     validation_set_provided = bool(validation_table)
     validation_aggregate_accuracy = []; validation_aggregate_loss = []
 
-    # Compute total buffers on each segment
-    total_buffers_per_seg = plpy.execute(
-        """ SELECT gp_segment_id, count(*) AS total_buffers_per_seg
-            FROM {0}
-            GROUP BY gp_segment_id
-        """.format(source_table))
-    seg_nums = [int(each_buffer["gp_segment_id"])
-        for each_buffer in total_buffers_per_seg]
+    optimizers = get_optimizers()
 
 Review comment:
   Hmm, good point, not sure why that is here. Will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services