You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Scott Gray <sc...@hotwaxmedia.com> on 2010/07/02 09:47:09 UTC
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
Regards
Scott
HotWax Media
http://www.hotwaxmedia.com
On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
> Author: erwan
> Date: Fri Jul 2 07:41:13 2010
> New Revision: 959894
>
> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
> Log:
> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>
> Modified:
> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>
> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
> URL: http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
> ==============================================================================
> --- ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original)
> +++ ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010
> @@ -117,6 +117,8 @@ under the License.
> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js" global="true"/>
> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/>
> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/>
> + <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}" default-value="${groovy:locale.toString()}"/>
> + <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/>
> <set field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/>
> <set field="layoutSettings.javaScripts[]" value="/images/fieldlookup.js" global="true"/>
> @@ -316,6 +318,7 @@ under the License.
> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/>
> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/>
> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}" default-value="${groovy:locale.toString()}"/>
> + <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/>
> <set field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/>
> <set field="layoutSettings.javaScripts[]" value="/images/fieldlookup.js" global="true"/>
>
>
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks guys,
Yslow is actually helpful, should be ok at r960491
Jacques
From: "Adam Heath" <do...@brainfood.com>
> Scott Gray wrote:
>> 1. Checkout OFBiz
>> 2. ant run-install
>> 3. sh startofbiz.sh
>> 4. Navigate to: http://localhost:8080/ecommerce
>> 5. This is in safari but similar can be done with firebug or whatever: Develop -> Show Error Console
>>
>> The error console tells me:
>> Failed to load resource: the server responded with a status of 404 (Not Found)
>> And if I click the link next to the error I can see the browser request that got 404'd which is what I've pasted in below.
>>
>> The point I originally made was that we shouldn't be telling the browser to retrieve a javascript file that doesn't exist. Is
>> this problem some sort of blocker to usability? No. But I don't really like the fact that every OFBiz page references a file
>> that we know is going to get 404'd.
>
> Install firefox, install yslow. It'll tell you what resources for a
> page are not found.
>
>>
>> Regards
>> Scott
>>
>> On 5/07/2010, at 10:47 AM, Jacques Le Roux wrote:
>>
>>> Thanks Scott,
>>>
>>> Could you give more information in order to try to reproduce? Are you passing this URL directly (I mean manually typed not
>>> internally generated)?
>>> In other word is it only theorical or a real problem reproductible from/in OFBiz itself?
>>> Because we have not a reall web app for image, try for instance http://localhost:8080/images/index.jsp which is supposed to
>>> exist web.xml of images.
>>> I mean you will get the same error for any files that is not there, and we resaonably can't have all the possible
>>> languages-regions combination in images/calendarDateSelect/locale/ which would the only real solution I guess. Do you see
>>> another, are we missing something else?
>>>
>>> Jacques
>>>
>>> Scott Gray wrote:
>>>> Same result:
>>>> Request URL:http://localhost:8080/images/calendarDateSelect/locale/en_US.js
>>>> Request Method:GET
>>>> Status Code:404 Not Found
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 5/07/2010, at 9:52 AM, Scott Gray wrote:
>>>>
>>>>> Thanks Jacques, updating now and will report back.
>>>>>
>>>>> Regarding the other issue I sure it is inadvertent so I've gone ahead and removed that reference and another that I came
>>>>> across.
>>>>>
>>>>> Thanks
>>>>> Scott
>>>>>
>>>>> On 5/07/2010, at 9:27 AM, Jacques Le Roux wrote:
>>>>>
>>>>>> Scott,
>>>>>>
>>>>>> Please update rather to r960401, thanks
>>>>>>
>>>>>> BTW in specialpurpose/ofbizwebsite/template/HtmlHead.ftl I found
>>>>>> <meta content="OFBiz, ofbiz support, ofbiz training, Ant websystems, outsource, outsourcing,framework, cheap, competitive,
>>>>>> ...
>>>>>> I don't want to begin a new flame war but I really wonder if it's "fair" to have such meta content (I put only the 1st 100
>>>>>> chars) in Apache OFBiz svn repo, even if I understand that it's a translated part of what was supposed to be used as the
>>>>>> official main OFBiz site...
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>>>> Hi Scott,
>>>>>>>
>>>>>>> I revisited this and indeed I really missed something at r886723 (in trunk some months ago). I tried a fix at r960336, but I
>>>>>>> can't easily test it
>>>>>>> Could you please check if it's OK for you now?
>>>>>>>
>>>>>>> I did not check yet but maybe I will have to merge improvements in jQuery branch. I put a comment in
>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-3830
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> Scott Gray wrote:
>>>>>>>> As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying
>>>>>>>> to
>>>>>>>> retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> Scott
>>>>>>>>
>>>>>>>> HotWax Media
>>>>>>>> http://www.hotwaxmedia.com
>>>>>>>>
>>>>>>>> On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
>>>>>>>>
>>>>>>>>> Author: erwan
>>>>>>>>> Date: Fri Jul 2 07:41:13 2010
>>>>>>>>> New Revision: 959894
>>>>>>>>>
>>>>>>>>> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
>>>>>>>>> Log:
>>>>>>>>> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>>>>>>>>>
>>>>>>>>> Modified:
>>>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>>>>>
>>>>>>>>> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>>>>> URL:
>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
>>>>>>>>> ============================================================================== ---
>>>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original) +++
>>>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010 @@ -117,6 +117,8 @@ under the
>>>>>>>>> License. <set field="layoutSettings.javaScripts[+0]"
>>>>>>>>> value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js"
>>>>>>>>> global="true"/> <set field="layoutSettings.javaScripts[+0]"
>>>>>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js"
>>>>>>>>> global="true"/> + <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set
>>>>>>>>> field="layoutSettings.javaScripts[]"
>>>>>>>>> value="/images/fieldlookup.js" global="true"/> @@ -316,6 +318,7 @@ under the License. <set
>>>>>>>>> field="layoutSettings.javaScripts[+0]"
>>>>>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js"
>>>>>>>>> global="true"/> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set
>>>>>>>>> field="layoutSettings.javaScripts[]"
>>>>>>>>> value="/images/fieldlookup.js" global="true"/>
>>>
>>
>
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
Posted by Adam Heath <do...@brainfood.com>.
Scott Gray wrote:
> 1. Checkout OFBiz
> 2. ant run-install
> 3. sh startofbiz.sh
> 4. Navigate to: http://localhost:8080/ecommerce
> 5. This is in safari but similar can be done with firebug or whatever: Develop -> Show Error Console
>
> The error console tells me:
> Failed to load resource: the server responded with a status of 404 (Not Found)
> And if I click the link next to the error I can see the browser request that got 404'd which is what I've pasted in below.
>
> The point I originally made was that we shouldn't be telling the browser to retrieve a javascript file that doesn't exist. Is this problem some sort of blocker to usability? No. But I don't really like the fact that every OFBiz page references a file that we know is going to get 404'd.
Install firefox, install yslow. It'll tell you what resources for a
page are not found.
>
> Regards
> Scott
>
> On 5/07/2010, at 10:47 AM, Jacques Le Roux wrote:
>
>> Thanks Scott,
>>
>> Could you give more information in order to try to reproduce? Are you passing this URL directly (I mean manually typed not internally generated)?
>> In other word is it only theorical or a real problem reproductible from/in OFBiz itself?
>> Because we have not a reall web app for image, try for instance http://localhost:8080/images/index.jsp which is supposed to exist web.xml of images.
>> I mean you will get the same error for any files that is not there, and we resaonably can't have all the possible languages-regions combination in images/calendarDateSelect/locale/ which would the only real solution I guess. Do you see another, are we missing something else?
>>
>> Jacques
>>
>> Scott Gray wrote:
>>> Same result:
>>> Request URL:http://localhost:8080/images/calendarDateSelect/locale/en_US.js
>>> Request Method:GET
>>> Status Code:404 Not Found
>>>
>>> Regards
>>> Scott
>>>
>>> On 5/07/2010, at 9:52 AM, Scott Gray wrote:
>>>
>>>> Thanks Jacques, updating now and will report back.
>>>>
>>>> Regarding the other issue I sure it is inadvertent so I've gone ahead and removed that reference and another that I came across.
>>>>
>>>> Thanks
>>>> Scott
>>>>
>>>> On 5/07/2010, at 9:27 AM, Jacques Le Roux wrote:
>>>>
>>>>> Scott,
>>>>>
>>>>> Please update rather to r960401, thanks
>>>>>
>>>>> BTW in specialpurpose/ofbizwebsite/template/HtmlHead.ftl I found
>>>>> <meta content="OFBiz, ofbiz support, ofbiz training, Ant websystems, outsource, outsourcing,framework, cheap, competitive, ...
>>>>> I don't want to begin a new flame war but I really wonder if it's "fair" to have such meta content (I put only the 1st 100
>>>>> chars) in Apache OFBiz svn repo, even if I understand that it's a translated part of what was supposed to be used as the
>>>>> official main OFBiz site...
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>>> Hi Scott,
>>>>>>
>>>>>> I revisited this and indeed I really missed something at r886723 (in trunk some months ago). I tried a fix at r960336, but I
>>>>>> can't easily test it
>>>>>> Could you please check if it's OK for you now?
>>>>>>
>>>>>> I did not check yet but maybe I will have to merge improvements in jQuery branch. I put a comment in
>>>>>> https://issues.apache.org/jira/browse/OFBIZ-3830
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> Scott Gray wrote:
>>>>>>> As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to
>>>>>>> retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
>>>>>>>
>>>>>>> Regards
>>>>>>> Scott
>>>>>>>
>>>>>>> HotWax Media
>>>>>>> http://www.hotwaxmedia.com
>>>>>>>
>>>>>>> On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
>>>>>>>
>>>>>>>> Author: erwan
>>>>>>>> Date: Fri Jul 2 07:41:13 2010
>>>>>>>> New Revision: 959894
>>>>>>>>
>>>>>>>> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
>>>>>>>> Log:
>>>>>>>> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>>>>
>>>>>>>> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>>>> URL:
>>>>>>>> http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
>>>>>>>> ============================================================================== ---
>>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original) +++
>>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010 @@ -117,6 +117,8 @@ under the
>>>>>>>> License. <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js"
>>>>>>>> global="true"/> <set field="layoutSettings.javaScripts[+0]"
>>>>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js"
>>>>>>>> global="true"/> + <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>>>>>> value="/images/fieldlookup.js" global="true"/> @@ -316,6 +318,7 @@ under the License. <set
>>>>>>>> field="layoutSettings.javaScripts[+0]"
>>>>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js"
>>>>>>>> global="true"/> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>>>>>> value="/images/fieldlookup.js" global="true"/>
>>
>
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
1. Checkout OFBiz
2. ant run-install
3. sh startofbiz.sh
4. Navigate to: http://localhost:8080/ecommerce
5. This is in safari but similar can be done with firebug or whatever: Develop -> Show Error Console
The error console tells me:
Failed to load resource: the server responded with a status of 404 (Not Found)
And if I click the link next to the error I can see the browser request that got 404'd which is what I've pasted in below.
The point I originally made was that we shouldn't be telling the browser to retrieve a javascript file that doesn't exist. Is this problem some sort of blocker to usability? No. But I don't really like the fact that every OFBiz page references a file that we know is going to get 404'd.
Regards
Scott
On 5/07/2010, at 10:47 AM, Jacques Le Roux wrote:
> Thanks Scott,
>
> Could you give more information in order to try to reproduce? Are you passing this URL directly (I mean manually typed not internally generated)?
> In other word is it only theorical or a real problem reproductible from/in OFBiz itself?
> Because we have not a reall web app for image, try for instance http://localhost:8080/images/index.jsp which is supposed to exist web.xml of images.
> I mean you will get the same error for any files that is not there, and we resaonably can't have all the possible languages-regions combination in images/calendarDateSelect/locale/ which would the only real solution I guess. Do you see another, are we missing something else?
>
> Jacques
>
> Scott Gray wrote:
>> Same result:
>> Request URL:http://localhost:8080/images/calendarDateSelect/locale/en_US.js
>> Request Method:GET
>> Status Code:404 Not Found
>>
>> Regards
>> Scott
>>
>> On 5/07/2010, at 9:52 AM, Scott Gray wrote:
>>
>>> Thanks Jacques, updating now and will report back.
>>>
>>> Regarding the other issue I sure it is inadvertent so I've gone ahead and removed that reference and another that I came across.
>>>
>>> Thanks
>>> Scott
>>>
>>> On 5/07/2010, at 9:27 AM, Jacques Le Roux wrote:
>>>
>>>> Scott,
>>>>
>>>> Please update rather to r960401, thanks
>>>>
>>>> BTW in specialpurpose/ofbizwebsite/template/HtmlHead.ftl I found
>>>> <meta content="OFBiz, ofbiz support, ofbiz training, Ant websystems, outsource, outsourcing,framework, cheap, competitive, ...
>>>> I don't want to begin a new flame war but I really wonder if it's "fair" to have such meta content (I put only the 1st 100
>>>> chars) in Apache OFBiz svn repo, even if I understand that it's a translated part of what was supposed to be used as the
>>>> official main OFBiz site...
>>>>
>>>> Jacques
>>>>
>>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>>> Hi Scott,
>>>>>
>>>>> I revisited this and indeed I really missed something at r886723 (in trunk some months ago). I tried a fix at r960336, but I
>>>>> can't easily test it
>>>>> Could you please check if it's OK for you now?
>>>>>
>>>>> I did not check yet but maybe I will have to merge improvements in jQuery branch. I put a comment in
>>>>> https://issues.apache.org/jira/browse/OFBIZ-3830
>>>>>
>>>>> Thanks
>>>>>
>>>>> Jacques
>>>>>
>>>>> Scott Gray wrote:
>>>>>> As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to
>>>>>> retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
>>>>>>
>>>>>> Regards
>>>>>> Scott
>>>>>>
>>>>>> HotWax Media
>>>>>> http://www.hotwaxmedia.com
>>>>>>
>>>>>> On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
>>>>>>
>>>>>>> Author: erwan
>>>>>>> Date: Fri Jul 2 07:41:13 2010
>>>>>>> New Revision: 959894
>>>>>>>
>>>>>>> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
>>>>>>> Log:
>>>>>>> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>>>>>>>
>>>>>>> Modified:
>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>>>
>>>>>>> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>>> URL:
>>>>>>> http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
>>>>>>> ============================================================================== ---
>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original) +++
>>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010 @@ -117,6 +117,8 @@ under the
>>>>>>> License. <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js"
>>>>>>> global="true"/> <set field="layoutSettings.javaScripts[+0]"
>>>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js"
>>>>>>> global="true"/> + <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>>>>> value="/images/fieldlookup.js" global="true"/> @@ -316,6 +318,7 @@ under the License. <set
>>>>>>> field="layoutSettings.javaScripts[+0]"
>>>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js"
>>>>>>> global="true"/> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>>>>> value="/images/fieldlookup.js" global="true"/>
>
>
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Scott,
Could you give more information in order to try to reproduce? Are you passing this URL directly (I mean manually typed not
internally generated)?
In other word is it only theorical or a real problem reproductible from/in OFBiz itself?
Because we have not a reall web app for image, try for instance http://localhost:8080/images/index.jsp which is supposed to exist
web.xml of images.
I mean you will get the same error for any files that is not there, and we resaonably can't have all the possible languages-regions
combination in images/calendarDateSelect/locale/ which would the only real solution I guess. Do you see another, are we missing
something else?
Jacques
Scott Gray wrote:
> Same result:
> Request URL:http://localhost:8080/images/calendarDateSelect/locale/en_US.js
> Request Method:GET
> Status Code:404 Not Found
>
> Regards
> Scott
>
> On 5/07/2010, at 9:52 AM, Scott Gray wrote:
>
>> Thanks Jacques, updating now and will report back.
>>
>> Regarding the other issue I sure it is inadvertent so I've gone ahead and removed that reference and another that I came across.
>>
>> Thanks
>> Scott
>>
>> On 5/07/2010, at 9:27 AM, Jacques Le Roux wrote:
>>
>>> Scott,
>>>
>>> Please update rather to r960401, thanks
>>>
>>> BTW in specialpurpose/ofbizwebsite/template/HtmlHead.ftl I found
>>> <meta content="OFBiz, ofbiz support, ofbiz training, Ant websystems, outsource, outsourcing,framework, cheap, competitive, ...
>>> I don't want to begin a new flame war but I really wonder if it's "fair" to have such meta content (I put only the 1st 100
>>> chars) in Apache OFBiz svn repo, even if I understand that it's a translated part of what was supposed to be used as the
>>> official main OFBiz site...
>>>
>>> Jacques
>>>
>>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>>> Hi Scott,
>>>>
>>>> I revisited this and indeed I really missed something at r886723 (in trunk some months ago). I tried a fix at r960336, but I
>>>> can't easily test it
>>>> Could you please check if it's OK for you now?
>>>>
>>>> I did not check yet but maybe I will have to merge improvements in jQuery branch. I put a comment in
>>>> https://issues.apache.org/jira/browse/OFBIZ-3830
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>> Scott Gray wrote:
>>>>> As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to
>>>>> retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> HotWax Media
>>>>> http://www.hotwaxmedia.com
>>>>>
>>>>> On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
>>>>>
>>>>>> Author: erwan
>>>>>> Date: Fri Jul 2 07:41:13 2010
>>>>>> New Revision: 959894
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
>>>>>> Log:
>>>>>> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>>
>>>>>> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
>>>>>> ============================================================================== ---
>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original) +++
>>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010 @@ -117,6 +117,8 @@ under the
>>>>>> License. <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js"
>>>>>> global="true"/> <set field="layoutSettings.javaScripts[+0]"
>>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js"
>>>>>> global="true"/> + <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>>>> value="/images/fieldlookup.js" global="true"/> @@ -316,6 +318,7 @@ under the License. <set
>>>>>> field="layoutSettings.javaScripts[+0]"
>>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js"
>>>>>> global="true"/> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>>>> value="/images/fieldlookup.js" global="true"/>
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
Same result:
Request URL:http://localhost:8080/images/calendarDateSelect/locale/en_US.js
Request Method:GET
Status Code:404 Not Found
Regards
Scott
On 5/07/2010, at 9:52 AM, Scott Gray wrote:
> Thanks Jacques, updating now and will report back.
>
> Regarding the other issue I sure it is inadvertent so I've gone ahead and removed that reference and another that I came across.
>
> Thanks
> Scott
>
> On 5/07/2010, at 9:27 AM, Jacques Le Roux wrote:
>
>> Scott,
>>
>> Please update rather to r960401, thanks
>>
>> BTW in specialpurpose/ofbizwebsite/template/HtmlHead.ftl I found
>> <meta content="OFBiz, ofbiz support, ofbiz training, Ant websystems, outsource, outsourcing,framework, cheap, competitive, ...
>> I don't want to begin a new flame war but I really wonder if it's "fair" to have such meta content (I put only the 1st 100 chars) in
>> Apache OFBiz svn repo, even if I understand that it's a translated part of what was supposed to be used as the official main OFBiz
>> site...
>>
>> Jacques
>>
>> From: "Jacques Le Roux" <ja...@les7arts.com>
>>> Hi Scott,
>>>
>>> I revisited this and indeed I really missed something at r886723 (in trunk some months ago). I tried a fix at r960336, but I can't
>>> easily test it
>>> Could you please check if it's OK for you now?
>>>
>>> I did not check yet but maybe I will have to merge improvements in jQuery branch. I put a comment in
>>> https://issues.apache.org/jira/browse/OFBIZ-3830
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>> Scott Gray wrote:
>>>> As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to
>>>> retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> HotWax Media
>>>> http://www.hotwaxmedia.com
>>>>
>>>> On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
>>>>
>>>>> Author: erwan
>>>>> Date: Fri Jul 2 07:41:13 2010
>>>>> New Revision: 959894
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
>>>>> Log:
>>>>> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>>>>>
>>>>> Modified:
>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>>
>>>>> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
>>>>> ============================================================================== ---
>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original) +++
>>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010 @@ -117,6 +117,8 @@ under the License.
>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js"
>>>>> global="true"/> <set field="layoutSettings.javaScripts[+0]"
>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/> +
>>>>> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>>> value="/images/fieldlookup.js" global="true"/> @@ -316,6 +318,7 @@ under the License. <set
>>>>> field="layoutSettings.javaScripts[+0]"
>>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/>
>>>>> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>>> value="/images/fieldlookup.js" global="true"/>
>>>
>>>
>>
>>
>
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
Thanks Jacques, updating now and will report back.
Regarding the other issue I sure it is inadvertent so I've gone ahead and removed that reference and another that I came across.
Thanks
Scott
On 5/07/2010, at 9:27 AM, Jacques Le Roux wrote:
> Scott,
>
> Please update rather to r960401, thanks
>
> BTW in specialpurpose/ofbizwebsite/template/HtmlHead.ftl I found
> <meta content="OFBiz, ofbiz support, ofbiz training, Ant websystems, outsource, outsourcing,framework, cheap, competitive, ...
> I don't want to begin a new flame war but I really wonder if it's "fair" to have such meta content (I put only the 1st 100 chars) in
> Apache OFBiz svn repo, even if I understand that it's a translated part of what was supposed to be used as the official main OFBiz
> site...
>
> Jacques
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
>> Hi Scott,
>>
>> I revisited this and indeed I really missed something at r886723 (in trunk some months ago). I tried a fix at r960336, but I can't
>> easily test it
>> Could you please check if it's OK for you now?
>>
>> I did not check yet but maybe I will have to merge improvements in jQuery branch. I put a comment in
>> https://issues.apache.org/jira/browse/OFBIZ-3830
>>
>> Thanks
>>
>> Jacques
>>
>> Scott Gray wrote:
>>> As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to
>>> retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
>>>
>>> Regards
>>> Scott
>>>
>>> HotWax Media
>>> http://www.hotwaxmedia.com
>>>
>>> On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
>>>
>>>> Author: erwan
>>>> Date: Fri Jul 2 07:41:13 2010
>>>> New Revision: 959894
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
>>>> Log:
>>>> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>>>>
>>>> Modified:
>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>>
>>>> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
>>>> ============================================================================== ---
>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original) +++
>>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010 @@ -117,6 +117,8 @@ under the License.
>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js"
>>>> global="true"/> <set field="layoutSettings.javaScripts[+0]"
>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/> +
>>>> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>> value="/images/fieldlookup.js" global="true"/> @@ -316,6 +318,7 @@ under the License. <set
>>>> field="layoutSettings.javaScripts[+0]"
>>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/>
>>>> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>>> value="/images/fieldlookup.js" global="true"/>
>>
>>
>
>
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Scott,
Please update rather to r960401, thanks
BTW in specialpurpose/ofbizwebsite/template/HtmlHead.ftl I found
<meta content="OFBiz, ofbiz support, ofbiz training, Ant websystems, outsource, outsourcing,framework, cheap, competitive, ...
I don't want to begin a new flame war but I really wonder if it's "fair" to have such meta content (I put only the 1st 100 chars) in
Apache OFBiz svn repo, even if I understand that it's a translated part of what was supposed to be used as the official main OFBiz
site...
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
> Hi Scott,
>
> I revisited this and indeed I really missed something at r886723 (in trunk some months ago). I tried a fix at r960336, but I can't
> easily test it
> Could you please check if it's OK for you now?
>
> I did not check yet but maybe I will have to merge improvements in jQuery branch. I put a comment in
> https://issues.apache.org/jira/browse/OFBIZ-3830
>
> Thanks
>
> Jacques
>
> Scott Gray wrote:
>> As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to
>> retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
>>
>> Regards
>> Scott
>>
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
>>
>>> Author: erwan
>>> Date: Fri Jul 2 07:41:13 2010
>>> New Revision: 959894
>>>
>>> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
>>> Log:
>>> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>>>
>>> Modified:
>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>>
>>> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
>>> ============================================================================== ---
>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original) +++
>>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010 @@ -117,6 +117,8 @@ under the License.
>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js"
>>> global="true"/> <set field="layoutSettings.javaScripts[+0]"
>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/> +
>>> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>> value="/images/fieldlookup.js" global="true"/> @@ -316,6 +318,7 @@ under the License. <set
>>> field="layoutSettings.javaScripts[+0]"
>>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/>
>>> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>>> value="/images/fieldlookup.js" global="true"/>
>
>
Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Scott,
I revisited this and indeed I really missed something at r886723 (in trunk some months ago). I tried a fix at r960336, but I can't
easily test it
Could you please check if it's OK for you now?
I did not check yet but maybe I will have to merge improvements in jQuery branch. I put a comment in
https://issues.apache.org/jira/browse/OFBIZ-3830
Thanks
Jacques
Scott Gray wrote:
> As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to
> retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it.
>
> Regards
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 2/07/2010, at 7:41 PM, erwan@apache.org wrote:
>
>> Author: erwan
>> Date: Fri Jul 2 07:41:13 2010
>> New Revision: 959894
>>
>> URL: http://svn.apache.org/viewvc?rev=959894&view=rev
>> Log:
>> Improvement on OFBIZ-3830 - i18n for jQuery calendar
>>
>> Modified:
>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>>
>> Modified: ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml?rev=959894&r1=959893&r2=959894&view=diff
>> ============================================================================== ---
>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml (original) +++
>> ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml Fri Jul 2 07:41:13 2010 @@ -117,6 +117,8 @@ under the License.
>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.2.custom.min.js"
>> global="true"/> <set field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/> +
>> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>> value="/images/fieldlookup.js" global="true"/> @@ -316,6 +318,7 @@ under the License. <set
>> field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-0.5.js" global="true"/> <set
>> field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/ui/jquery.ui.datepicker.js" global="true"/>
>> <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}"
>> default-value="${groovy:locale.toString()}"/> + <set field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js" global="true"/>
>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.4.2.js" global="true"/> <set
>> field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="layoutSettings.javaScripts[]"
>> value="/images/fieldlookup.js" global="true"/>