You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2023/02/09 12:55:04 UTC

[GitHub] [arrow-datafusion] Jefffrey commented on a diff in pull request #5225: Fix doc links and typos

Jefffrey commented on code in PR #5225:
URL: https://github.com/apache/arrow-datafusion/pull/5225#discussion_r1101426823


##########
datafusion/expr/src/expr_rewriter.rs:
##########
@@ -84,6 +84,8 @@ pub enum RewriteRecursion {
 /// # See Also:
 /// * [`Expr::accept`] to drive a rewriter through an [`Expr`]
 /// * [`rewrite_expr`]: For rewriting an [`Expr`] using functions
+///
+/// [`Expr::accept`]: crate::expr_visitor::ExprVisitable::accept

Review Comment:
   this isn't the right link, but i couldn't figure out how to link to the `Expr` method implementation instead of just the `ExprVisitable` trait method itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org