[GitHub] [incubator-echarts] dr-itz commented on issue #8490: Add null checks for setAxisModel

[GitBox <gi...@apache.org>]

dr-itz commented on issue #8490: Add null checks for setAxisModel
URL: https://github.com/apache/incubator-echarts/pull/8490#issuecomment-515700408
 
 
   This solves crashes we see an high frequency. These crashed basically block us from rolling out echarts. 👍 
   
   @pissang @Ovilia @deqingli may I ask you to consider merging this fix? Also, a release containing the fix would be highly appreciated
   
   Also, a guy from our team (hi Akash) found this to reproduce the problem:
   
   ```
   option = {
       xAxis: {
           type: 'category',
           boundaryGap: false,
           
       },
       yAxis: {
           type: 'value'
       },
       series: [{
           data: [['Tue',820]],
           type: 'line',
           areaStyle: {}
       }],
       dataZoom:[{
           type:'slider',
           startValue:'mon'
       }]
   };
   ```
   
   While this is "invalid" in the context here, it shouldn't crash. Also we see this with "time" axis, but there the reproducer isn't clear.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org