[jira] [Commented] (IMPALA-8652) Illegal delimiter error in shell has "unknown exception" as part of error message

["Jiawei Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868111#comment-16868111 ] 

Jiawei Wang commented on IMPALA-8652:
-------------------------------------

Hi, [~tarmstrong],

Sorry I am a newbie, I am still trying to understand the code base. I have found the exception and where it was threw. 

It happened inside impala_shell._execute_stmt() function. The _format_outputstream() function raise an ValueError and the execute_stmt() function does not have a corresponding catch block. So it becomes a Unknown Exception.


Are you suggesting we check the output_delimiter first and then run the query? What do you think is the expected output? Or what change will you apply if you are fixing this?
Thanks so much for the advise! I will fix this as soon as I got a plan.


Best,

Jiawei


> Illegal delimiter error in shell has "unknown exception" as part of error message
> ---------------------------------------------------------------------------------
>
>                 Key: IMPALA-8652
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8652
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>    Affects Versions: Impala 3.2.0
>            Reporter: Tim Armstrong
>            Assignee: Jiawei Wang
>            Priority: Minor
>              Labels: newbie, ramp-up
>
> Repro:
> {noformat}
> $ impala-shell.sh -B --output_delimiter '||' -q 'select 1,1,1'
> Starting Impala Shell without Kerberos authentication
> Opened TCP connection to localhost:21000
> Connected to localhost:21000
> Server version: impalad version 3.3.0-SNAPSHOT DEBUG (build a0d96078a522ee72b1fbcedb5629451123afbfd0)
> Query: select 1,1,1
> Query submitted at: 2019-06-11 13:15:11 (Coordinator: http://tarmstrong-box:25000)
> Query progress can be monitored at: http://tarmstrong-box:25000/query_plan?query_id=f14a14db36e6157c:aadd29bf00000000
> Unknown Exception : Illegal delimiter ||, the delimiter must be a 1-character string.
> Could not execute command: select 1,1,1
> {noformat}
> We have a test for this error message, but it only does a substring match.
> I think the issue is that the validation of the argument is done only after the query is running, and ValueError is raised in DelimitedOutputFormatter and caught in a different place from most argument errors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org