You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/04 17:27:26 UTC
[GitHub] [apisix-dashboard] starsz opened a new pull request #1431: feat: support -v command to show version
starsz opened a new pull request #1431:
URL: https://github.com/apache/apisix-dashboard/pull/1431
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
fix #1405
___
### New feature or improvement
- Describe the details and related test reports.
support -v command to show version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1431: feat: support -v command to show version
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #1431:
URL: https://github.com/apache/apisix-dashboard/pull/1431#discussion_r570656608
##########
File path: api/cmd/managerapi.go
##########
@@ -135,6 +144,7 @@ func NewManagerAPICommand() *cobra.Command {
}
cmd.PersistentFlags().StringVarP(&conf.WorkDir, "work-dir", "p", ".", "current work directory")
+ cmd.PersistentFlags().BoolVarP(&showVersion, "show_version", "v", false, "show manager api-version")
Review comment:
I think the long option name just can be "version".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz merged pull request #1431: feat: support -v command to show version
Posted by GitBox <gi...@apache.org>.
starsz merged pull request #1431:
URL: https://github.com/apache/apisix-dashboard/pull/1431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1431: feat: support -v command to show version
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #1431:
URL: https://github.com/apache/apisix-dashboard/pull/1431#discussion_r570656608
##########
File path: api/cmd/managerapi.go
##########
@@ -135,6 +144,7 @@ func NewManagerAPICommand() *cobra.Command {
}
cmd.PersistentFlags().StringVarP(&conf.WorkDir, "work-dir", "p", ".", "current work directory")
+ cmd.PersistentFlags().BoolVarP(&showVersion, "show_version", "v", false, "show manager api-version")
Review comment:
I think the long option name just can be "version".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1431: feat: support -v command to show version
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1431:
URL: https://github.com/apache/apisix-dashboard/pull/1431#discussion_r570657533
##########
File path: api/cmd/managerapi.go
##########
@@ -135,6 +144,7 @@ func NewManagerAPICommand() *cobra.Command {
}
cmd.PersistentFlags().StringVarP(&conf.WorkDir, "work-dir", "p", ".", "current work directory")
+ cmd.PersistentFlags().BoolVarP(&showVersion, "show_version", "v", false, "show manager api-version")
Review comment:
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz merged pull request #1431: feat: support -v command to show version
Posted by GitBox <gi...@apache.org>.
starsz merged pull request #1431:
URL: https://github.com/apache/apisix-dashboard/pull/1431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1431: feat: support -v command to show version
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1431:
URL: https://github.com/apache/apisix-dashboard/pull/1431#discussion_r570657533
##########
File path: api/cmd/managerapi.go
##########
@@ -135,6 +144,7 @@ func NewManagerAPICommand() *cobra.Command {
}
cmd.PersistentFlags().StringVarP(&conf.WorkDir, "work-dir", "p", ".", "current work directory")
+ cmd.PersistentFlags().BoolVarP(&showVersion, "show_version", "v", false, "show manager api-version")
Review comment:
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org