You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2026/06/12 07:02:04 UTC

[PR] feat: Version history UI for Explore and Dashboard [superset]

kgabryje opened a new pull request, #40988:
URL: https://github.com/apache/superset/pull/40988

   > [!IMPORTANT]
   > **⚠️ STACKED PR — built on the unmerged versioning backend.** This branch is based at `71355883b9` on `mikebridge:sc-107283-versioning-activity-view` (the activity-view follow-up to the versioning backend PR #39603). Most commits in the diff belong to that backend work — **this PR's own changes are ONLY the last 7 commits** (`71355883b9..931c4df51b`, all prefixed `(version-history)`). It will be rebased onto `master` once the backend lands. Kept as **draft** until then and until the manual browser walkthrough is complete.
   
   ### SUMMARY
   
   Adds a version history UI for charts (Explore) and dashboards, entirely behind a new `VERSION_HISTORY` feature flag (default **off**).
   
   - **Panel**: a 320px inline right-side "Version history" panel on both Explore and Dashboard, opened from each page's kebab menu (or `?version_history=1`). Shows an activity timeline with client-side search, an include filter (All changes / This chart·dashboard only / Related items only), and "Load more" pagination.
   - **Timeline**: self changes are grouped per save transaction — granular per-control rows for charts, compact "Filters · N changes" / "Edit mode · N changes" containers for dashboards. Related rows ("Dataset updated: …") link to the entity (plain text when deleted), with impact-aware phrasing when a dataset change affects multiple charts. A pinned "Current version" section tracks unsaved work-in-progress (per-control session log on Explore, coarse unsaved-edits entry on Dashboard) and surfaces a restore notice when the newest save is a restore.
   - **Preview**: clicking a version previews it point-in-time — charts render in an isolated `SuperChart` that never touches the live Explore redux state; dashboards re-hydrate from the snapshot (live charts) and restore the live state on close. A banner shows the previewed version with Restore / Open as new / Close actions; page actions are disabled while previewing.
   - **Restore**: confirmation modal, `POST .../versions/{uuid}/restore`, success/failure toasts, and in-place rehydration of the page afterwards (Explore re-fetches the explore payload and re-queries; Dashboard re-hydrates fresh data).
   - **Open as new**: forks the selected version into a new chart/dashboard ("[Name] (copy from Dec 5)") in a new tab.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Will be added during the manual walkthrough (PR is draft until then).
   
   ### TESTING INSTRUCTIONS
   
   1. Enable the `VERSION_HISTORY` feature flag (requires the stacked versioning backend).
   2. Open a chart in Explore or a dashboard, open the kebab menu → "Version history".
   3. Exercise search, the include filter, pagination, preview (banner + disabled page actions), restore (confirm modal + toast + page reload in place), and "Open as new chart/dashboard".
   
   Automated coverage:
   - Full `npm run type` passes with zero errors.
   - 139 jest tests green, including 51 new tests for this feature (activity grouping, redux slice, display formatting, panel interactions, preview banner restore round-trip incl. failure path, session-log middleware).
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Required feature flags: `VERSION_HISTORY`
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-5704343176

   # 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️❗ @kgabryje Your base branch `master` has also updated `superset/migrations`.
   
   **Please consider rebasing your branch and [resolving potential db migration conflicts](https://superset.apache.org/docs/contributing/development#merging-db-migrations).**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-5763312622

   # 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️❗ @kgabryje Your base branch `master` has also updated `superset/migrations`.
   
   **Please consider rebasing your branch and [resolving potential db migration conflicts](https://superset.apache.org/docs/contributing/development#merging-db-migrations).**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-6022156573

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-5706353436

   # 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️❗ @kgabryje Your base branch `master` has also updated `superset/migrations`.
   
   **Please consider rebasing your branch and [resolving potential db migration conflicts](https://superset.apache.org/docs/contributing/development#merging-db-migrations).**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-6281393727

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-4688297844

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-6455866148

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-4695527217

   @kgabryje Four of the five items are addressed on the backend stack; one comes with an honest caveat:
   
   1. **Machine-written fields**: `perm`/`schema_perm`/`catalog_perm` excluded from versioning entirely (the phantom transactions no longer exist, not just the records); `shared_label_colors` suppressed from change records. → you can revert those `NOISE_PATHS` entries.
   2. **One save → two transactions**: ⚠️ **keep your adjacent-merge workaround for dataset saves.** We merged update+refresh into one transaction, then found (and verified with session tracing) that `DBEventLogger` commits/rolls back the shared scoped session mid-request — single-transaction saves can lose or half-commit work, so we reverted to per-command commits. The real fix is event-logger session hygiene, tracked for the refinement pass. If your tx=49/50 repro was *not* an `override_columns` save, send the request log and we'll dig further.
   3. **First-save explosion**: every activity record now carries `first_tracked_save: true|false` — collapse on that instead of heuristics. (Always `false` for hard-deleted entities; the marker matches the live row's `(id, uuid)`.)
   4. **Restore target**: restore transactions carry a synthetic headline record — `kind: "__meta__"`, `operation: "announce"`, `path: ["__meta__"]`, `to_value: {version_uuid, version_number}` — rendered server-side as "… restored to version N" (on `include=self` too). Clients branching on `operation` should treat `announce` records as annotations, not edits.
   5. **Server-side search**: `?q=` on `/activity/` searches the full history pre-pagination; `count` reflects the matches; values match in their JSON form (`false`, `null`, quoted keys). Debounce client-side — it re-evaluates the full history per request.
   
   ⚠️ **Rebase target**: `2c957b9edc` on `mikebridge:sc-107283-versioning-activity-view` — your base `71355883b9` is orphaned history (the stack was rebased onto current master for the alembic-head fix plus review fixes). The branch history should be stable from here on; you have downstream consumers now, so any further rewrites will be coordinated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-4688324930

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 931c4df51b23f64a985d0ed75cf421026ff40c44 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a2baeec5d2944000802ece9 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40988--superset-docs-preview.netlify.app](https://deploy-preview-40988--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQwOTg4LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.HLhYK6P0fm-BKQVsv-N2DGKk0RNAzm7rHbpEcxjXZg4)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5YROz7Ac9Q9elhFLRCiL6e97mMC_kko58wgzQgSs20tZcSfQ4alTi5lJDiiGu4gqteM57ehbfkrbSWWYavDRKIeKEkokNfD8) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-40988--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-4692785659

   Small addendum to the machine-written-fields item above: the bulk chart rewrites carry **both** `schema_perm` and `catalog_perm` records (verified on the same transaction — suppressing only `schema_perm` still left the phantom rows). Both are now in the client `NOISE_PATHS` workaround. For a backend fix, the whole permission-string class is probably worth excluding from activity (`perm` itself would presumably flood the same way if rewritten in bulk, though we haven't observed it).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-5786544867

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-6307957023

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-4692762968

   > while wiring the version-history UI to the activity endpoint (this PR stacks on `sc-107283-versioning-activity-view`), a few backend behaviors surfaced that we're currently papering over client-side.
   
   @kgabryje Thanks, yeah, once the breaking-change window is lifted I'll merge soft-deletions and then work to refine the activity log all together with the rest of the versioning branches.  I know there are some pre-existing oddities that we may have to work around---here is another example where the round-trip was asymmetrical and led to noise in the logs: https://github.com/apache/superset/pull/39706.  I'm sure there are more.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-5719097312

   # 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️ 🙅‍♂️❗ @kgabryje Your base branch `master` has also updated `superset/migrations`.
   
   **Please consider rebasing your branch and [resolving potential db migration conflicts](https://superset.apache.org/docs/contributing/development#merging-db-migrations).**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-5067205001

   @kgabryje looks like the version-history UI now lives in @mikebridge's #41551 tracker. Should we close this one, or is it still carrying work that isn't folded in there yet?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-5941599107

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-4692627875

   @mikebridge — while wiring the version-history UI to the activity endpoint (this PR stacks on `sc-107283-versioning-activity-view`), a few backend behaviors surfaced that we're currently papering over client-side. Flagging so they can be fixed at the source. Each client workaround is marked with a greppable `backend workaround` TODO (mostly in `superset-frontend/src/features/versionHistory/grouping.ts`) and is intended to be reverted once addressed.
   
   **1. Machine-written fields pollute the activity stream**
   - `json_metadata.shared_label_colors` gets rewritten when a dashboard is merely *viewed* → phantom 1-record "Properties updated" transactions (no user edit), plus ride-along records inside real saves.
   - `schema_perm` on charts gets rewritten in bulk by permission maintenance. In our test env one transaction (tx=53) carried 24 records: 3 self records from the actual user save + 10 related charts × `schema_perm` — the panel showed a flood of 10 "Chart updated" rows for a single save.
   - Workaround: client-side `NOISE_PATHS` suppression for both paths. Ideally system-managed writes wouldn't be recorded as user-visible changes (or would be flagged so clients can filter server-side).
   
   **2. One logical save → two transactions**
   A single dataset save produced tx=49 (9 column records) and tx=50 (4 column edits + a folders add), both stamped the same second, same entity — rendering as two "Dataset updated" rows for one user action.
   - Workaround: adjacent-merge of related rows for the same entity within a 60s window. Inherently fragile — one transaction per logical save would remove it.
   
   **3. First Explore save of a legacy chart explodes into ~74 records**
   Initial params normalization writes dozens of change records in one transaction. UI caps it (10 visible + "Show N more changes"), but a normalization/baseline marker on such transactions would let clients present this properly.
   
   **4. Restore transactions don't reference their target**
   `action_kind=restore` is present, but the transaction carries no pointer to *which* version was restored, so "Restored to '[action]' from [date]" can't be rendered from API data alone.
   
   **5. Server-side search**
   Panel search currently filters loaded pages only. A query param on the activity endpoint would make search cover full history.
   
   None of these block this PR — the UI handles them — but 1 and 2 distort the timeline for users, and the workarounds should be reverted when fixed (grep `backend workaround`).
   
   (Minor: a 1-line `package-lock.json` sync rides along in this PR.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-5953084604

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-6070746529

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-6102863128

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-6461080230

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Version history UI for Explore and Dashboard [superset]

Posted by "github-actions[bot] (via GitHub) via notifications" <no...@superset.apache.org>.
github-actions[bot] commented on PR #40988:
URL: https://github.com/apache/superset/pull/40988#issuecomment-6589603140

   ### ⚠️ Possible DB migration conflict
   
   @kgabryje the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.
   
   To check and, if needed, fix this:
   
   1. Rebase this branch onto the latest `master`.
   2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
   3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.
   
   See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org