[GitHub] [incubator-tvm] comaniac opened a new pull request #5732: [TOPI][ARM] Fix reshape usage in ARM schedule

[GitBox <gi...@apache.org>]

comaniac opened a new pull request #5732:
URL: https://github.com/apache/incubator-tvm/pull/5732


   After #5429, it requires the new shape of `relay.reshape` can only be either `int`, `Tuple[int, ...]`, `List[int]`, or `Expr`. However, a use case in ARM conv2d alter layout passes `Tuple[int, int, Expr, int]` that violates the reshape spec.
   
   Considering `CO` and `VC` should be constants at this moment, it should be safe to directly use division.
   
   @icemelon9 please help verify.
   
   tl; dr
   The root cause is the new added `const` call in reshape. This statement tries to convert a list type of new shape to `Expr` by calling `const(newshape)`. Specifically, it does the following:
   
   1. Make a numpy array.
   2. Refer to the numpy array type and shape to create an empty NDArray.
   
   The problem is that a list `[3, 3, idxd(10, 2), 4]` will become an object type numpy array, which NDArray.empty cannot handle.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #5732: [TOPI][ARM] Fix reshape usage in ARM schedule

[GitBox <gi...@apache.org>]

tqchen merged pull request #5732:
URL: https://github.com/apache/incubator-tvm/pull/5732


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org