You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2013/10/06 23:38:51 UTC

RE: svn commit: r1529676 - in /subversion/trunk/subversion/svnserve: serve.c server.h


> -----Original Message-----
> From: stefan2@apache.org [mailto:stefan2@apache.org]
> Sent: zondag 6 oktober 2013 22:25
> To: commits@subversion.apache.org
> Subject: svn commit: r1529676 - in /subversion/trunk/subversion/svnserve: serve.c
> server.h
> 
> Author: stefan2
> Date: Sun Oct  6 20:25:20 2013
> New Revision: 1529676
> 
> URL: http://svn.apache.org/r1529676
> Log:
> In svnserve, move the repository-specific data of the server
> baton into a separate data structure.  Update a gazillion users.
> 
> This is the first in a series of commits attempting to separate
> connection specific, repository specific and global data.  Once
> that has been achieved, we can move towards suspendable sessions.
> The latter is required when serving a (quasi) unlimited number
> of connections through a limited number of threads.

This patch breaks building on all buildbots. Probably because all of them enable cyrus sasl while your build doesn't.

Linux:
[[
subversion/svnserve/cyrus_auth.c: In function 'cyrus_auth_request':
subversion/svnserve/cyrus_auth.c:268: error: 'server_baton_t' has no member named 'realm'
subversion/svnserve/cyrus_auth.c:292: error: 'server_baton_t' has no member named 'cfg'
subversion/svnserve/cyrus_auth.c:298: error: 'server_baton_t' has no member named 'cfg'
subversion/svnserve/cyrus_auth.c:332: error: 'server_baton_t' has no member named 'realm'
make: *** [subversion/svnserve/cyrus_auth.lo] Error 1
make: *** Waiting for unfinished jobs....
subversion/svnserve/serve.c: In function 'auth_request':
subversion/svnserve/serve.c:744: error: 'server_baton_t' has no member named 'use_sasl'
make: *** [subversion/svnserve/serve.lo] Error 1
+ exit 2
]]

Windows:
[[
       "D:\svn-w2k3-local\slik-w2k3-x64-local\build\subversion_vcnet.sln" (__ALL_TESTS__ target) (1) ->
       (Programs\svnserve target) -> 
         ..\..\..\subversion\svnserve\cyrus_auth.c(268): error C2039: 'realm' : is not a member of 'server_baton_t'
         ..\..\..\subversion\svnserve\cyrus_auth.c(270): error C4047: 'function' : 'const sasl_callback_t *' differs in levels of indirection from 'int'
         ..\..\..\subversion\svnserve\cyrus_auth.c(270): error C4024: 'sasl_server_new' : different types for formal and actual parameter 6
         ..\..\..\subversion\svnserve\cyrus_auth.c(271): error C4047: 'function' : 'unsigned int' differs in levels of indirection from 'sasl_conn_t **'
         ..\..\..\subversion\svnserve\cyrus_auth.c(271): error C4024: 'sasl_server_new' : different types for formal and actual parameter 7
         ..\..\..\subversion\svnserve\cyrus_auth.c(271): error C2198: 'sasl_server_new' : too few arguments for call
         ..\..\..\subversion\svnserve\cyrus_auth.c(292): error C2039: 'cfg' : is not a member of 'server_baton_t'
         ..\..\..\subversion\svnserve\cyrus_auth.c(292): error C4047: 'function' : 'svn_config_t *' differs in levels of indirection from 'const char **'
         ..\..\..\subversion\svnserve\cyrus_auth.c(292): error C4024: 'svn_config_get' : different types for formal and actual parameter 1
         ..\..\..\subversion\svnserve\cyrus_auth.c(293): error C4047: 'function' : 'const char **' differs in levels of indirection from 'char [5]'
         ..\..\..\subversion\svnserve\cyrus_auth.c(293): error C4024: 'svn_config_get' : different types for formal and actual parameter 2
         ..\..\..\subversion\svnserve\cyrus_auth.c(295): error C2198: 'svn_config_get' : too few arguments for call
         ..\..\..\subversion\svnserve\cyrus_auth.c(298): error C2039: 'cfg' : is not a member of 'server_baton_t'
         ..\..\..\subversion\svnserve\cyrus_auth.c(298): error C4047: 'function' : 'svn_config_t *' differs in levels of indirection from 'const char **'
         ..\..\..\subversion\svnserve\cyrus_auth.c(298): error C4024: 'svn_config_get' : different types for formal and actual parameter 1
         ..\..\..\subversion\svnserve\cyrus_auth.c(299): error C4047: 'function' : 'const char **' differs in levels of indirection from 'char [5]'
         ..\..\..\subversion\svnserve\cyrus_auth.c(299): error C4024: 'svn_config_get' : different types for formal and actual parameter 2
         ..\..\..\subversion\svnserve\cyrus_auth.c(301): error C2198: 'svn_config_get' : too few arguments for call
         ..\..\..\subversion\svnserve\cyrus_auth.c(333): error C2039: 'realm' : is not a member of 'server_baton_t'
         ..\..\..\subversion\svnserve\serve.c(744): error C2039: 'use_sasl' : is not a member of 'server_baton_t'
]]

	Bert 



Re: svn commit: r1529676 - in /subversion/trunk/subversion/svnserve: serve.c server.h

Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Sun, Oct 6, 2013 at 11:38 PM, Bert Huijben <be...@qqmail.nl> wrote:

>
>
> > -----Original Message-----
> > From: stefan2@apache.org [mailto:stefan2@apache.org]
> > Sent: zondag 6 oktober 2013 22:25
> > To: commits@subversion.apache.org
> > Subject: svn commit: r1529676 - in
> /subversion/trunk/subversion/svnserve: serve.c
> > server.h
> >
> > Author: stefan2
> > Date: Sun Oct  6 20:25:20 2013
> > New Revision: 1529676
> >
> > URL: http://svn.apache.org/r1529676
> > Log:
> > In svnserve, move the repository-specific data of the server
> > baton into a separate data structure.  Update a gazillion users.
> >
> > This is the first in a series of commits attempting to separate
> > connection specific, repository specific and global data.  Once
> > that has been achieved, we can move towards suspendable sessions.
> > The latter is required when serving a (quasi) unlimited number
> > of connections through a limited number of threads.
>
> This patch breaks building on all buildbots. Probably because all of them
> enable cyrus sasl while your build doesn't.
>

Sorry! Fixed.

-- Stefan^2.