You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2021/10/21 19:25:26 UTC
Review Request 73665: RANGER-3488:Docker setup for Apache Ranger Knox
plugin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73665/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3488
https://issues.apache.org/jira/browse/RANGER-3488
Repository: ranger
Description
-------
RANGER-3488:Docker setup for Apache Ranger Knox plugin
Diffs
-----
agents-installer/pom.xml 76c2961b3
dev-support/ranger-docker/.dockerignore e42d86501
dev-support/ranger-docker/.env 100ed71d8
dev-support/ranger-docker/Dockerfile.ranger 894001492
dev-support/ranger-docker/Dockerfile.ranger-base 3fa657b80
dev-support/ranger-docker/Dockerfile.ranger-knox PRE-CREATION
dev-support/ranger-docker/docker-compose.ranger-knox.yml PRE-CREATION
dev-support/ranger-docker/download-archives.sh e107be09b
dev-support/ranger-docker/scripts/ranger-hadoop-mkdir.sh de16245ca
dev-support/ranger-docker/scripts/ranger-knox-expect.sh PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox-plugin-install.properties PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox-service-dev_knox.py PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox-setup.sh PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox.sh PRE-CREATION
dev-support/ranger-docker/scripts/ranger.sh 04ac7cb4b
distro/src/main/assembly/knox-agent.xml c1f16d62f
Diff: https://reviews.apache.org/r/73665/diff/1/
Testing
-------
- Verified by bringing up docker image with knox in a container.
Thanks,
Ramesh Mani
Re: Review Request 73665: RANGER-3488:Docker setup for Apache Ranger
Knox plugin
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73665/#review223663
-----------------------------------------------------------
@Ramesh - good to see addition of docker setup for Ranger plugins. Thank you. Couple of suggestions:
- README.txt (5.2) should be updated to include Knox container build and startup
- Setup Knox with at least one topology (webhdfs), to demostrate Ranger plugin in action
dev-support/ranger-docker/Dockerfile.ranger-base
Lines 22 (patched)
<https://reviews.apache.org/r/73665/#comment312763>
Since 'expect' is needed only in Knox container, consider moving its installation to Dockerfile.ranger-knox.
dev-support/ranger-docker/docker-compose.ranger-knox.yml
Lines 17 (patched)
<https://reviews.apache.org/r/73665/#comment312764>
Consider exposing the port Knox listens on with the following:
ports:
- "8443:8443"
- Madhan Neethiraj
On Oct. 21, 2021, 7:25 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73665/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2021, 7:25 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3488
> https://issues.apache.org/jira/browse/RANGER-3488
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3488:Docker setup for Apache Ranger Knox plugin
>
>
> Diffs
> -----
>
> agents-installer/pom.xml 76c2961b3
> dev-support/ranger-docker/.dockerignore e42d86501
> dev-support/ranger-docker/.env 100ed71d8
> dev-support/ranger-docker/Dockerfile.ranger 894001492
> dev-support/ranger-docker/Dockerfile.ranger-base 3fa657b80
> dev-support/ranger-docker/Dockerfile.ranger-knox PRE-CREATION
> dev-support/ranger-docker/docker-compose.ranger-knox.yml PRE-CREATION
> dev-support/ranger-docker/download-archives.sh e107be09b
> dev-support/ranger-docker/scripts/ranger-hadoop-mkdir.sh de16245ca
> dev-support/ranger-docker/scripts/ranger-knox-expect.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-plugin-install.properties PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-service-dev_knox.py PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-setup.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger.sh 04ac7cb4b
> distro/src/main/assembly/knox-agent.xml c1f16d62f
>
>
> Diff: https://reviews.apache.org/r/73665/diff/1/
>
>
> Testing
> -------
>
> - Verified by bringing up docker image with knox in a container.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73665: RANGER-3488:Docker setup for Apache Ranger
Knox plugin
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73665/#review223665
-----------------------------------------------------------
Ship it!
Ship It!
- bhavik patel
On Oct. 25, 2021, 4:27 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73665/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2021, 4:27 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3488
> https://issues.apache.org/jira/browse/RANGER-3488
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3488:Docker setup for Apache Ranger Knox plugin
>
>
> Diffs
> -----
>
> agents-installer/pom.xml a970115be
> dev-support/ranger-docker/.dockerignore e42d86501
> dev-support/ranger-docker/.env 787780db0
> dev-support/ranger-docker/Dockerfile.ranger 894001492
> dev-support/ranger-docker/Dockerfile.ranger-base 3fa657b80
> dev-support/ranger-docker/Dockerfile.ranger-knox PRE-CREATION
> dev-support/ranger-docker/README.md 6fb96591f
> dev-support/ranger-docker/docker-compose.ranger-knox.yml PRE-CREATION
> dev-support/ranger-docker/download-archives.sh e107be09b
> dev-support/ranger-docker/scripts/ranger-hadoop-mkdir.sh de16245ca
> dev-support/ranger-docker/scripts/ranger-hadoop-setup.sh fa22613ed
> dev-support/ranger-docker/scripts/ranger-knox-expect.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-plugin-install.properties PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-sandbox.xml PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-service-dev_knox.py PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-setup.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger.sh 04ac7cb4b
> distro/src/main/assembly/knox-agent.xml ceeb78c04
> knox-agent/pom.xml 49623c3db
>
>
> Diff: https://reviews.apache.org/r/73665/diff/2/
>
>
> Testing
> -------
>
> - Verified by bringing up docker image with knox in a container.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73665: RANGER-3488:Docker setup for Apache Ranger
Knox plugin
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73665/#review223664
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 25, 2021, 4:27 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73665/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2021, 4:27 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3488
> https://issues.apache.org/jira/browse/RANGER-3488
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3488:Docker setup for Apache Ranger Knox plugin
>
>
> Diffs
> -----
>
> agents-installer/pom.xml a970115be
> dev-support/ranger-docker/.dockerignore e42d86501
> dev-support/ranger-docker/.env 787780db0
> dev-support/ranger-docker/Dockerfile.ranger 894001492
> dev-support/ranger-docker/Dockerfile.ranger-base 3fa657b80
> dev-support/ranger-docker/Dockerfile.ranger-knox PRE-CREATION
> dev-support/ranger-docker/README.md 6fb96591f
> dev-support/ranger-docker/docker-compose.ranger-knox.yml PRE-CREATION
> dev-support/ranger-docker/download-archives.sh e107be09b
> dev-support/ranger-docker/scripts/ranger-hadoop-mkdir.sh de16245ca
> dev-support/ranger-docker/scripts/ranger-hadoop-setup.sh fa22613ed
> dev-support/ranger-docker/scripts/ranger-knox-expect.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-plugin-install.properties PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-sandbox.xml PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-service-dev_knox.py PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-setup.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger.sh 04ac7cb4b
> distro/src/main/assembly/knox-agent.xml ceeb78c04
> knox-agent/pom.xml 49623c3db
>
>
> Diff: https://reviews.apache.org/r/73665/diff/2/
>
>
> Testing
> -------
>
> - Verified by bringing up docker image with knox in a container.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73665: RANGER-3488:Docker setup for Apache Ranger
Knox plugin
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73665/
-----------------------------------------------------------
(Updated Oct. 25, 2021, 4:27 a.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Fixed review comments
Bugs: RANGER-3488
https://issues.apache.org/jira/browse/RANGER-3488
Repository: ranger
Description
-------
RANGER-3488:Docker setup for Apache Ranger Knox plugin
Diffs (updated)
-----
agents-installer/pom.xml a970115be
dev-support/ranger-docker/.dockerignore e42d86501
dev-support/ranger-docker/.env 787780db0
dev-support/ranger-docker/Dockerfile.ranger 894001492
dev-support/ranger-docker/Dockerfile.ranger-base 3fa657b80
dev-support/ranger-docker/Dockerfile.ranger-knox PRE-CREATION
dev-support/ranger-docker/README.md 6fb96591f
dev-support/ranger-docker/docker-compose.ranger-knox.yml PRE-CREATION
dev-support/ranger-docker/download-archives.sh e107be09b
dev-support/ranger-docker/scripts/ranger-hadoop-mkdir.sh de16245ca
dev-support/ranger-docker/scripts/ranger-hadoop-setup.sh fa22613ed
dev-support/ranger-docker/scripts/ranger-knox-expect.sh PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox-plugin-install.properties PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox-sandbox.xml PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox-service-dev_knox.py PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox-setup.sh PRE-CREATION
dev-support/ranger-docker/scripts/ranger-knox.sh PRE-CREATION
dev-support/ranger-docker/scripts/ranger.sh 04ac7cb4b
distro/src/main/assembly/knox-agent.xml ceeb78c04
knox-agent/pom.xml 49623c3db
Diff: https://reviews.apache.org/r/73665/diff/2/
Changes: https://reviews.apache.org/r/73665/diff/1-2/
Testing
-------
- Verified by bringing up docker image with knox in a container.
Thanks,
Ramesh Mani
Re: Review Request 73665: RANGER-3488:Docker setup for Apache Ranger
Knox plugin
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73665/#review223661
-----------------------------------------------------------
dev-support/ranger-docker/scripts/ranger-hadoop-mkdir.sh
Lines 35 (patched)
<https://reviews.apache.org/r/73665/#comment312760>
any specific reason for adding "knox" as group? as for other directory we have used "hadoop" group.
- bhavik patel
On Oct. 21, 2021, 7:25 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73665/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2021, 7:25 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3488
> https://issues.apache.org/jira/browse/RANGER-3488
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3488:Docker setup for Apache Ranger Knox plugin
>
>
> Diffs
> -----
>
> agents-installer/pom.xml 76c2961b3
> dev-support/ranger-docker/.dockerignore e42d86501
> dev-support/ranger-docker/.env 100ed71d8
> dev-support/ranger-docker/Dockerfile.ranger 894001492
> dev-support/ranger-docker/Dockerfile.ranger-base 3fa657b80
> dev-support/ranger-docker/Dockerfile.ranger-knox PRE-CREATION
> dev-support/ranger-docker/docker-compose.ranger-knox.yml PRE-CREATION
> dev-support/ranger-docker/download-archives.sh e107be09b
> dev-support/ranger-docker/scripts/ranger-hadoop-mkdir.sh de16245ca
> dev-support/ranger-docker/scripts/ranger-knox-expect.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-plugin-install.properties PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-service-dev_knox.py PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox-setup.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger-knox.sh PRE-CREATION
> dev-support/ranger-docker/scripts/ranger.sh 04ac7cb4b
> distro/src/main/assembly/knox-agent.xml c1f16d62f
>
>
> Diff: https://reviews.apache.org/r/73665/diff/1/
>
>
> Testing
> -------
>
> - Verified by bringing up docker image with knox in a container.
>
>
> Thanks,
>
> Ramesh Mani
>
>