You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ponymail.apache.org by GitBox <gi...@apache.org> on 2020/08/11 12:01:37 UTC

[GitHub] [incubator-ponymail] sbp commented on pull request #517: Add DKIM style ID generation

sbp commented on pull request #517:
URL: https://github.com/apache/incubator-ponymail/pull/517#issuecomment-671903245


   Please note that this PR also adds an extra parameter passing the bytes of the original message to the `compute_updates` and `generator` functions in `archiver.py` and `generators.py` respectively. This is because the DKIM style ID generator works on the original bytes, and recovering these from `msg.as_bytes()` is not only slower but also more fragile in that the behaviour of that method depends on the upstream implementation in the Python standard library.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org