You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2016/11/07 19:56:12 UTC
[Impala-ASF-CR] IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4976
Change subject: IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
......................................................................
IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
In some development environments, the ParserTests may always fail with an
java.lang.UnsatisfiedLinkError:
org.apache.impala.service.FeSupport.NativeGetStartupOptions()[B
at o.a.i.service.FeSupport.NativeGetStartupOptions(Native Method)
at o.a.i.service.FeSupport.GetStartupOptions(FeSupport.java:268)
at o.a.i.common.RuntimeEnv.<init>(RuntimeEnv.java:47)
at o.a.i.common.RuntimeEnv.<clinit>(RuntimeEnv.java:34)
at o.a.i.testutil.TestUtils.assumeKuduIsSupported(TestUtils.java:288)
at o.a.i.analysis.ParserTest.TestKuduUpdate(ParserTest.java:1697)
I believe the issue is related to some static loading of
classes and/or libraries in Java because changing the
ParserTest to initialize the Frontend makes the error go
away. I haven't been able to pin-point the exact issue with
loading, but it makes sense that the ParserTest should
initialize the Frontend static state if it will be called by
libfesupport later since it seems to be an issue affecting
some environments and not others, i.e. subject to
environmental factors.
This fixes the issue by changing ParserTest to extend
FrontendTestBase which initializes the Frontend class
statically.
Change-Id: I1828504f79c51679f9ca07176bffbe248d450e87
---
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
1 file changed, 2 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/4976/1
--
To view, visit http://gerrit.cloudera.org:8080/4976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1828504f79c51679f9ca07176bffbe248d450e87
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
......................................................................
IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
In some development environments, the ParserTests may always fail with an
java.lang.UnsatisfiedLinkError:
org.apache.impala.service.FeSupport.NativeGetStartupOptions()[B
at o.a.i.service.FeSupport.NativeGetStartupOptions(Native Method)
at o.a.i.service.FeSupport.GetStartupOptions(FeSupport.java:268)
at o.a.i.common.RuntimeEnv.<init>(RuntimeEnv.java:47)
at o.a.i.common.RuntimeEnv.<clinit>(RuntimeEnv.java:34)
at o.a.i.testutil.TestUtils.assumeKuduIsSupported(TestUtils.java:288)
at o.a.i.analysis.ParserTest.TestKuduUpdate(ParserTest.java:1697)
I believe the issue is related to some static loading of
classes and/or libraries in Java because changing the
ParserTest to initialize the Frontend makes the error go
away. I haven't been able to pin-point the exact issue with
loading, but it makes sense that the ParserTest should
initialize the Frontend static state if it will be called by
libfesupport later since it seems to be an issue affecting
some environments and not others, i.e. subject to
environmental factors.
This fixes the issue by changing ParserTest to extend
FrontendTestBase which initializes the Frontend class
statically.
Change-Id: I1828504f79c51679f9ca07176bffbe248d450e87
Reviewed-on: http://gerrit.cloudera.org:8080/4976
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
1 file changed, 2 insertions(+), 20 deletions(-)
Approvals:
Internal Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1828504f79c51679f9ca07176bffbe248d450e87
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
[Impala-ASF-CR] IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1828504f79c51679f9ca07176bffbe248d450e87
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1828504f79c51679f9ca07176bffbe248d450e87
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No