[GitHub] [spark] cloud-fan commented on a change in pull request #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24721: [SPARK-27856][SQL] do not forcibly add cast when inserting table
URL: https://github.com/apache/spark/pull/24721#discussion_r287800626
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -2268,123 +2268,6 @@ class Analyzer(
     }
   }
 
-  /**
-   * Resolves columns of an output table from the data in a logical plan. This rule will:
-   *
-   * - Reorder columns when the write is by name
-   * - Insert safe casts when data types do not match
-   * - Insert aliases when column names do not match
-   * - Detect plans that are not compatible with the output table and throw AnalysisException
-   */
-  object ResolveOutputRelation extends Rule[LogicalPlan] {
 
 Review comment:
   move it outside of the `Analyzer` class, so that we can call its methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org