[GitHub] carbondata pull request #2650: [HOTFIX]Fixed Join Query Performance issue

[kumarvishal09 <gi...@git.apache.org>]

GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/2650

    [HOTFIX]Fixed Join Query Performance issue

    
    **Problem**
    Join Query is taking for time in case of carbon as for some of the Join Query it is not reusing the exchange plan(Scanning+Snuffle) this is because in ReuseExchange it checking same result of two plan is same or not, in case of carbon it always giving false as SparkCarbonTable equals method is not overridden and comparison is failing. 
    
    **Solution:** Added equals method in SparkCarbonTableFormat
    
    **Tested TPCH query** 
    Query:
    select c_name, c_custkey, o_orderkey, o_orderdate, o_totalprice, sum(l_quantity) from customer, orders, lineitem where o_orderkey in ( select l_orderkey from lineitem group by l_orderkey having sum(l_quantity) > 300 ) and c_custkey = o_custkey and o_orderkey = l_orderkey group by c_name, c_custkey, o_orderkey, o_orderdate, o_totalprice order by o_totalprice desc, o_orderdate;
    
    **Old Time:26 seconds
    New Time:20 seconds**
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata planfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2650
    
----
commit 62bb9bb5026a6c47f3cc208bb84ea7f381f9c3b2
Author: kumarvishal09 <ku...@...>
Date:   2018-08-23T08:30:55Z

    Fixed Join Plan issue

----


---

[GitHub] carbondata issue #2650: [HOTFIX]Fixed Join Query Performance issue

[ravipesala <gi...@git.apache.org>]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2650
  
    LGTM


---

[GitHub] carbondata issue #2650: [HOTFIX]Fixed Join Query Performance issue

[ravipesala <gi...@git.apache.org>]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2650
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6339/



---

[GitHub] carbondata issue #2650: [HOTFIX]Fixed Join Query Performance issue

[CarbonDataQA <gi...@git.apache.org>]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2650
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6712/



---

[GitHub] carbondata pull request #2650: [HOTFIX]Fixed Join Query Performance issue

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2650


---

[GitHub] carbondata issue #2650: [HOTFIX]Fixed Join Query Performance issue

[CarbonDataQA <gi...@git.apache.org>]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2650
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7988/



---