You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/08/22 16:25:42 UTC

[jira] [Created] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Harsh J created HBASE-6634:
------------------------------

             Summary: REST API ScannerModel's protobuf converter code duplicates the setBatch call
                 Key: HBASE-6634
                 URL: https://issues.apache.org/jira/browse/HBASE-6634
             Project: HBase
          Issue Type: Bug
          Components: rest
    Affects Versions: 0.94.0
            Reporter: Harsh J
            Priority: Trivial
         Attachments: HBASE-6634.patch

There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HBASE-6634:
---------------------------

    Attachment: HBASE-6634.patch
    
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Priority: Trivial
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6634:
-------------------------

       Resolution: Fixed
    Fix Version/s: 0.96.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Applied to trunk.  Thanks for reviews Michael and Ted.  Thanks for patch Mighty Harsh
                
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J reassigned HBASE-6634:
------------------------------

    Assignee: Harsh J
    
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456990#comment-13456990 ] 

Michael Drzal commented on HBASE-6634:
--------------------------------------

+1 on the patch.  That's really strange.
                
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457477#comment-13457477 ] 

Hudson commented on HBASE-6634:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #178 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/178/])
    HBASE-6634 REST API ScannerModel's protobuf converter code duplicates the setBatch call (Revision 1386816)

     Result = FAILURE
stack : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java

                
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439640#comment-13439640 ] 

Zhihong Ted Yu commented on HBASE-6634:
---------------------------------------

+1 on patch.
                
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439621#comment-13439621 ] 

Hadoop QA commented on HBASE-6634:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12541975/HBASE-6634.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

    -1 findbugs.  The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2646//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2646//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2646//console

This message is automatically generated.
                
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HBASE-6634:
---------------------------

    Status: Patch Available  (was: Open)
    
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6634) REST API ScannerModel's protobuf converter code duplicates the setBatch call

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457384#comment-13457384 ] 

Hudson commented on HBASE-6634:
-------------------------------

Integrated in HBase-TRUNK #3344 (See [https://builds.apache.org/job/HBase-TRUNK/3344/])
    HBASE-6634 REST API ScannerModel's protobuf converter code duplicates the setBatch call (Revision 1386816)

     Result = FAILURE
stack : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java

                
> REST API ScannerModel's protobuf converter code duplicates the setBatch call
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6634
>                 URL: https://issues.apache.org/jira/browse/HBASE-6634
>             Project: HBase
>          Issue Type: Bug
>          Components: rest
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6634.patch
>
>
> There's a dupe call to setBatch when a scanner model object is created for protobuf outputs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira