[GitHub] reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays

[gi...@git.apache.org]

reminisce commented on a change in pull request #7244: Operator add_n for row sparse ndarrays
URL: https://github.com/apache/incubator-mxnet/pull/7244#discussion_r130228405
 
 

 ##########
 File path: include/mxnet/ndarray.h
 ##########
 @@ -199,6 +199,11 @@ class NDArray {
     return ptr_->aux_shapes[i];
   }
 
+  const std::vector<TShape>& aux_shapes() const {
 
 Review comment:
   Member functions defined inside classes are automatically inline. There is no need to put the key word `inline` in front of it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services