[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230992#comment-17230992 ] 

ASF GitHub Bot commented on GEODE-8670:
---------------------------------------

bschuchardt opened a new pull request #5744:
URL: https://github.com/apache/geode/pull/5744


   1. Fixed all of the IgnorableException problems in ReconnectDUnitTest
   2. Modified InternalLocator to avoid throwing a NullPointerException and
      added a test for this change
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ReconnectDUnitTest is hiding a NullPointerException
> ---------------------------------------------------
>
>                 Key: GEODE-8670
>                 URL: https://issues.apache.org/jira/browse/GEODE-8670
>             Project: Geode
>          Issue Type: Test
>          Components: membership, tests
>    Affects Versions: 1.14.0
>            Reporter: Jens Deppe
>            Priority: Major
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is incorrect. Specifically it looks like this:
> {noformat}
>     IgnoredException.addIgnoredException("ForcedDisconnectException||Possible loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> -----------------------------------------------------------------------
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT <Location services restart thread> tid=203] Uncaught exception in thread Thread[Location services restart thread,5,RMI Runtime]
> java.lang.NullPointerException
> 	at org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> 	at org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> 	at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which probably just requires an addition to the other ignored exceptions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)