You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by pmoravec <gi...@git.apache.org> on 2017/04/22 14:48:27 UTC
[GitHub] qpid-dispatch pull request #160: DISPATCH-749 - unmap_all_addresses unmaps j...
GitHub user pmoravec opened a pull request:
https://github.com/apache/qpid-dispatch/pull/160
DISPATCH-749 - unmap_all_addresses unmaps just half of addresses
iterating over a list being updated needs deep copy of the list
Signed-off-by: Pavel Moravec <pm...@redhat.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pmoravec/qpid-dispatch DISPATCH-749
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 0d052c46da4e3f5faa356d61d22582521cbcb619
Author: Pavel Moravec <pm...@redhat.com>
Date: 2017-04-22T14:44:53Z
DISPATCH-749 - unmap_all_addresses unmaps just half of addresses
iterating over a list being updated needs deep copy of the list
Signed-off-by: Pavel Moravec <pm...@redhat.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #160: DISPATCH-749 - unmap_all_addresses unmaps just hal...
Posted by pmoravec <gi...@git.apache.org>.
Github user pmoravec commented on the issue:
https://github.com/apache/qpid-dispatch/pull/160
This approach (deep copy of the list and calling `.remove`) might be inefficient for long lists. If this can be an issue, some different approach shall be used, e.g.:
while len(self.mobile_addresses)>0:
self.unmap_address(self.mobile_addresses[0])
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #160: DISPATCH-749 - unmap_all_addresses unmaps just hal...
Posted by pmoravec <gi...@git.apache.org>.
Github user pmoravec commented on the issue:
https://github.com/apache/qpid-dispatch/pull/160
Rebased the PR to more efficient fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #160: DISPATCH-749 - unmap_all_addresses unmaps just hal...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on the issue:
https://github.com/apache/qpid-dispatch/pull/160
Can we do this instead
`while self.mobile_addresses:
self.unmap_address(self.mobile_addresses.pop(0))
`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #160: DISPATCH-749 - unmap_all_addresses unmaps j...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org