You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Brian Topping (JIRA)" <ji...@apache.org> on 2010/11/15 22:42:14 UTC
[jira] Created: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
---------------------------------------------------------------------
Key: WICKET-3173
URL: https://issues.apache.org/jira/browse/WICKET-3173
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.13
Reporter: Brian Topping
Priority: Critical
Attachments: WICKET-3173.patch
The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3173:
------------------------------------
Affects Version/s: 1.5-M3
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Brian Topping
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932511#action_12932511 ]
Igor Vaynberg commented on WICKET-3173:
---------------------------------------
no, we dont need to merge in 1.5. i dont think it should allow null, but its too late to fix in 1.4
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Brian Topping
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: test-WICKET-3173.patch, WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-3173:
-------------------------------------
Assignee: Igor Vaynberg
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Brian Topping
> Assignee: Igor Vaynberg
> Priority: Critical
> Attachments: WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Brian Topping (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Topping closed WICKET-3173.
---------------------------------
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Brian Topping
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: WICKET-3173.patch, test-WICKET-3173.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-3173:
-------------------------------------
Assignee: (was: Igor Vaynberg)
We need to merge the fix in 1.5.
org.apache.wicket.protocol.https.SwitchProtocolRequestHandler.SwitchProtocolRequestHandler(Protocol, IRequestHandler, HttpsConfig) does check for not-null which also needs to be removed.
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Brian Topping
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932224#action_12932224 ]
Hudson commented on WICKET-3173:
--------------------------------
Integrated in Apache Wicket 1.4.x #269 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/269/])
Issue: WICKET-3173
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Brian Topping
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Brian Topping (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Topping updated WICKET-3173:
----------------------------------
Attachment: WICKET-3173.patch
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Brian Topping
> Priority: Critical
> Attachments: WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3173:
---------------------------------
Attachment: test-WICKET-3173.patch
test case preventing this NPE
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Brian Topping
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: test-WICKET-3173.patch, WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932617#action_12932617 ]
Hudson commented on WICKET-3173:
--------------------------------
Integrated in Apache Wicket 1.4.x #273 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/273/])
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Brian Topping
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: test-WICKET-3173.patch, WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3173.
-----------------------------------
Resolution: Fixed
Assignee: Igor Vaynberg
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13, 1.5-M3
> Reporter: Brian Topping
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: test-WICKET-3173.patch, WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Brian Topping (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932316#action_12932316 ]
Brian Topping commented on WICKET-3173:
---------------------------------------
Thanks Igor!
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Brian Topping
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-3173:
----------------------------------
Priority: Minor (was: Critical)
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Brian Topping
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.14
>
> Attachments: WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3173) Fix for WICKET-2903 causes NPE when
HttpsConfig is intentionally null
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3173.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4.14
> Fix for WICKET-2903 causes NPE when HttpsConfig is intentionally null
> ---------------------------------------------------------------------
>
> Key: WICKET-3173
> URL: https://issues.apache.org/jira/browse/WICKET-3173
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.13
> Reporter: Brian Topping
> Assignee: Igor Vaynberg
> Priority: Critical
> Fix For: 1.4.14
>
> Attachments: WICKET-3173.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> The patch in WICKET-2903 is not as robust as it needs to be. Throughout the code in HttpsRequestCycleProcessor.java, there are a number of conditionals on whether portConfig is null, clearly making the null state an acceptable value. But HttpsRequestCycleProcessor.resolve() now calls portConfig.isPreferStateful() without first checking to see if the portConfig is null.
> For the interested, my application leaves portConfig set to null when I would like to avoid a redirect to https, for instance in development on a machine that does not have SSL set up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.