[jira] [Closed] (OAK-6051) Clarify migration tests failures when switching Commit#hasChanges implementations

["Davide Giannella (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-6051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davide Giannella closed OAK-6051.
---------------------------------

Bulk close for 1.7.3

> Clarify migration tests failures when switching Commit#hasChanges implementations
> ---------------------------------------------------------------------------------
>
>                 Key: OAK-6051
>                 URL: https://issues.apache.org/jira/browse/OAK-6051
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>             Fix For: 1.8, 1.7.3
>
>         Attachments: OAK-6051.patch
>
>
> Currently, the implementation used to tell if there are changes in a commit  to be merged (comparing the base state against the node state) uses {{SegmentNodeState#fastEquals}} directly (and consequently making that method public). Although comparing the node states through {{equals}}, which in turn should then delegate to {{fastEquals}}, should work, the following tests are failing when using this method:
> {code}
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.41 sec <<< FAILURE! - in org.apache.jackrabbit.oak.segment.migration.ExternalToExternalMigrationTest
> blobsExistsOnTheNewBlobStore(org.apache.jackrabbit.oak.segment.migration.ExternalToExternalMigrationTest)  Time elapsed: 0.082 sec  <<< ERROR!
> java.io.IOException: java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> Running org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.163 sec <<< FAILURE! - in org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest
> blobsExistsOnTheNewBlobStore(org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest)  Time elapsed: 0.062 sec  <<< ERROR!
> java.io.IOException: java.lang.NullPointerException
> Caused by: java.lang.NullPointerException
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)