You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/20 20:20:43 UTC
[GitHub] [pulsar] merlimat opened a new pull request #12103: Fixed used after recycle issue in OpAddEntry
merlimat opened a new pull request #12103:
URL: https://github.com/apache/pulsar/pull/12103
### Motivation
After a write failure, a task is scheduled in background to force close the ledger and trigger the creation of a new one. If the the `OpAddEntry` instance is already recycled, that could lead to either a NPE or undefined behavior.
### Modifications
Copy the reference to a final variable so the background task will not be dependent on the lifecycle of `OpAddEntry` instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall edited a comment on pull request #12103: Fixed used after recycle issue in OpAddEntry
Posted by GitBox <gi...@apache.org>.
michaeljmarshall edited a comment on pull request #12103:
URL: https://github.com/apache/pulsar/pull/12103#issuecomment-955067842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #12103: Fixed used after recycle issue in OpAddEntry
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12103:
URL: https://github.com/apache/pulsar/pull/12103#issuecomment-924547223
@merlimat Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #12103: Fixed used after recycle issue in OpAddEntry
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12103:
URL: https://github.com/apache/pulsar/pull/12103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #12103: Fixed used after recycle issue in OpAddEntry
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #12103:
URL: https://github.com/apache/pulsar/pull/12103#issuecomment-955268072
I don't think that would explain an out of order scenario, but yes, we should cherry pick into 2.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12103: Fixed used after recycle issue in OpAddEntry
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12103:
URL: https://github.com/apache/pulsar/pull/12103#issuecomment-955067842
@merlimat - I just ran into this NPE running 2.8.0. I am investigating a report of messages persisted out of order. Do you think this NPE could lead to such behavior? Could we cherry pick this to `branch-2.8` before we release 2.8.2? Also, if we're going to do another release for 2.7, should we cherry pick it to that branch? Let me know what you think? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org