You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/11 07:57:42 UTC

[GitHub] [airflow] mik-laj commented on issue #5402: [AIRFLOW-4746] Implement GCP Cloud Tasks' Hook and Operators

mik-laj commented on issue #5402: [AIRFLOW-4746] Implement GCP Cloud Tasks' Hook and Operators
URL: https://github.com/apache/airflow/pull/5402#issuecomment-500731180
 
 
   Pylint is sad
   ```
   Running pylint for source code without tests
   ************* Module airflow.contrib.hooks.gcp_tasks_hook
   airflow/contrib/hooks/gcp_tasks_hook.py:1:0: C0111: Missing module docstring (missing-docstring)
   airflow/contrib/hooks/gcp_tasks_hook.py:44:4: W0235: Useless super delegation in method '__init__' (useless-super-delegation)
   ************* Module airflow.contrib.operators.gcp_tasks_operator
   airflow/contrib/operators/gcp_tasks_operator.py:1:0: C0111: Missing module docstring (missing-docstring)
   airflow/contrib/operators/gcp_tasks_operator.py:600:4: R0913: Too many arguments (11/10) (too-many-arguments)
   -----------------------------------
   Your code has been rated at 9.97/10
   Running pylint for tests
   ************* Module tests.contrib.operators.test_gcp_tasks_operator
   tests/contrib/operators/test_gcp_tasks_operator.py:54:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:74:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:95:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:114:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:132:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:151:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:170:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:189:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:208:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:230:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:251:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:272:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   tests/contrib/operators/test_gcp_tasks_operator.py:292:8: C0103: Variable name "op" doesn't conform to snake_case naming style (invalid-name)
   -----------------------------------
   Your code has been rated at 9.36/10
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services