You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/01/12 06:27:57 UTC

[GitHub] zeppelin pull request #1889: [MINOR] Rename Pig tutorial note to consider pr...

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1889

    [MINOR] Rename Pig tutorial note to consider priority

    ### What is this PR for?
    After #1830 merged, Pig tutorial note placed as a first under `Zeppelin Tutorial` folder. I told to @zjffdu, I thought the note name should be same with Spark ("Basic Feature (Spark)") in [this comment](https://github.com/apache/zeppelin/pull/1830#discussion_r95522394) (because they have same contents). 
    
    <img src="https://cloud.githubusercontent.com/assets/10060731/21879248/a6d9b88a-d8da-11e6-8f43-5ef192e5895c.png" width="300px">
    
    But considering the number of Spark and Pig users, the Spark tutorial note needs to be placed as first I think.
    
    <img src="https://cloud.githubusercontent.com/assets/10060731/21879244/a488e3d0-d8da-11e6-9e0b-c91ca890c611.png" width="300px">
     
    ### What type of PR is it?
    Rename Pig tutorial note 
    
    ### What is the Jira issue?
    N/A
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin rename/pigTutorialNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1889.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1889
    
----
commit f08fd6910bcfb2f5ea3960fc76e08df34c102db3
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2017-01-12T06:15:14Z

    Rename Pig tutorial note to consider priority

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1889: [MINOR] Rename Pig tutorial note to consider priority

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1889
  
    Yup merge into both master and branch-0.7 if there are no more comments 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1889: [MINOR] Rename Pig tutorial note to consider priority

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1889
  
    @zjffdu Sorry for the confusion. If you don't mind, could you take a look into this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1889: [MINOR] Rename Pig tutorial note to consider priority

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1889
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1889: [MINOR] Rename Pig tutorial note to consider pr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1889


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1889: [MINOR] Rename Pig tutorial note to consider priority

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/1889
  
    Let's merge it now. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---