You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/18 12:02:06 UTC
[GitHub] [skywalking] beiwangnull opened a new issue #5349: plugin GRPC not support TLS
beiwangnull opened a new issue #5349:
URL: https://github.com/apache/skywalking/issues/5349
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Bug
- Which version of SkyWalking, OS and JRE?
Skywalking 8.0.2 jdk 8
Caused by: java.lang.IllegalStateException: Exit span doesn't include meaningful peer information.
at org.apache.skywalking.apm.agent.core.context.TracingContext.inject(TracingContext.java:170)
at org.apache.skywalking.apm.agent.core.context.TracingContext.inject(TracingContext.java:150)
at org.apache.skywalking.apm.agent.core.context.ContextManager.inject(ContextManager.java:123)
at org.apache.skywalking.apm.plugin.grpc.v1.client.TracingClientCall.start(TracingClientCall.java:84)
at io.grpc.stub.ClientCalls.startCall(ClientCalls.java:315)
at io.grpc.stub.ClientCalls.asyncUnaryRequestCall(ClientCalls.java:287)
at io.grpc.stub.ClientCalls.futureUnaryCall(ClientCalls.java:196)
at io.etcd.jetcd.api.KVGrpc$KVFutureStub.range(KVGrpc.java:507)
at io.etcd.jetcd.KVImpl.lambda$get$3(KVImpl.java:112)
at io.etcd.jetcd.ClientConnectionManager.lambda$execute$4(ClientConnectionManager.java:306)
at net.jodah.failsafe.Functions.lambda$toCtxSupplier$15(Functions.java:276)
at net.jodah.failsafe.Functions.lambda$getPromise$1(Functions.java:81)
at net.jodah.failsafe.Functions.lambda$null$3(Functions.java:103)
at net.jodah.failsafe.internal.util.DelegatingScheduler.lambda$schedule$0(DelegatingScheduler.java:141)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] francis177 commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
francis177 commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683263710
> After some debug, I found the cause of the bug.
> The Jetcd Client builder will use `ClientConnectionManager` to build `ManagedChannel` with `SmartNameResolverFactory`.
> When the authority has not been set, SmartNameResolverFactory will be initialized with an empty string authority.
>
> ```java
> // io.etcd.jetcd.ClientConnectionManager
> channelBuilder.nameResolverFactory(
> forEndpoints(
> Util.supplyIfNull(builder.authority(), () -> ""),
> builder.endpoints(),
> Util.supplyIfNull(builder.uriResolverLoader(),
> URIResolverLoader::defaultLoader)));
> ```
>
> >> @beiwangnull
> you can set the value of authority explicitly to avoid the bug for now.
>
> ```kotlin
> val client = Client.builder()
> .sslContext(context)
> .endpoints("http://server-host:2712")
> .authority("etcd") // Must be a SAN in server cert if <server-host> is not in cert
> .build()
> ```
>
> Reference: [etcd-io/jetcd#55](https://github.com/etcd-io/jetcd/issues/55), [etcd-io/jetcd#652](https://github.com/etcd-io/jetcd/issues/652), [grpc/grpc-java#2662](https://github.com/grpc/grpc-java/pull/2662)
>
> >> @wu-sheng
> We need to discuss how we do if we can't get authority from `ManagedChannel`, the name resolver could override the original value of authority.
When using jetcd to connect etcd cluster via mTLS, the server cert will contain more than one domain, aka. etcd-1.com, etcd-2.com, etcd-3.com. Because .authority() accept single string. Separately, etcd-1.com or etcd-2.com or etcd-3.com as authority is all fine. How can I set all these there domains into jetcd client's authority ? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] francis177 commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
francis177 commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683646886
@devkanro I set etcd cluster's endpoints []String as client's endpoint, not single etcd node
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683265197
@francis177 Could you make your question clear? How to use jetcd is not SkyWalking's concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-685445435
> @devkanro We just need the remote name or network address. I think we could get that from the stub initialization, right?
@wu-sheng
The remote name or network address will not be resolved in stub initialization...
The `ManagedChannelImpl` will call the start method of `NameResolver`, and use the listener to get resolve result.
Maybe hook the stub is not a good choose, we should focus on the `NameResolver` or `SmartNameResolver`.
Support `NameResolver` for all cases, `SmartNameResolver` for jetcd case. `NameResolver` supporting will be a little complex, `SmartNameResolver` will be easy to support.
For jetcd case, we can detect the grpc client created by jetcd client, and set the default authority to `ExitSpan` if authority not be set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683397861
@devkanro What is the progress of this issue locating?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng removed a comment on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng removed a comment on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675450517
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675789563
@devkanro Could you take a look on this? Include my comment about the `injection` not working. From the codes, this is caused by `peer` that doesn't exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-922757588
No activity for months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-679808855
After some debug, I found the cause of the bug.
The Client builder will use `ClientConnectionManager` to build `ManagedChannel` with `SmartNameResolverFactory`.
When the authority has not been set, SmartNameResolverFactory will be initialized with an empty string authority.
```Java
channelBuilder.nameResolverFactory(
forEndpoints(
Util.supplyIfNull(builder.authority(), () -> ""),
builder.endpoints(),
Util.supplyIfNull(builder.uriResolverLoader(),
URIResolverLoader::defaultLoader)));
```
\>\> @beiwangnull
you can set the value of authority explicitly to avoid the bug for now.
```Kotlin
val client = Client.builder()
.sslContext(context)
.endpoints("http://server-host:2712")
.authority("etcd") // Must be a SAN in server cert if <server-host> is not in cert
.build()
```
Reference: etcd-io/jetcd#55, etcd-io/jetcd#652, grpc/grpc-java#2662
\>\> @wu-sheng
We need to discuss how we do if we can't get authority from `ManagedChannel`, the name resolver could override the original value of authority.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-678628455
@beiwangnull
I need more information about your bug case.
Do you use the [Mutual TLS](https://github.com/grpc/grpc-java/blob/master/SECURITY.md#mutual-tls) in your client? or just the server-side TLS?
Could you provide a simple project to recurrent the bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683399982
I am trying to change the plugin to fix this issue...
The intercept point of grpc plugin is the ClientCall now, I'm looking for getting authority from stubs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683376990
Just make your authority same as one domain in your cert, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675818264
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro edited a comment on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro edited a comment on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675810204
@wu-sheng sure, assign to me pls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675456780
@beiwangnull Could you try to move https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/client/TracingClientCall.java#L84 to line 91?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro edited a comment on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro edited a comment on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-679808855
After some debug, I found the cause of the bug.
The Jetcd Client builder will use `ClientConnectionManager` to build `ManagedChannel` with `SmartNameResolverFactory`.
When the authority has not been set, SmartNameResolverFactory will be initialized with an empty string authority.
```Java
channelBuilder.nameResolverFactory(
forEndpoints(
Util.supplyIfNull(builder.authority(), () -> ""),
builder.endpoints(),
Util.supplyIfNull(builder.uriResolverLoader(),
URIResolverLoader::defaultLoader)));
```
\>\> @beiwangnull
you can set the value of authority explicitly to avoid the bug for now.
```Kotlin
val client = Client.builder()
.sslContext(context)
.endpoints("http://server-host:2712")
.authority("etcd") // Must be a SAN in server cert if <server-host> is not in cert
.build()
```
Reference: etcd-io/jetcd#55, etcd-io/jetcd#652, grpc/grpc-java#2662
\>\> @wu-sheng
We need to discuss how we do if we can't get authority from `ManagedChannel`, the name resolver could override the original value of authority.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro edited a comment on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro edited a comment on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-679808855
After some debug, I found the cause of the bug.
The Jetcd Client builder will use `ClientConnectionManager` to build `ManagedChannel` with `SmartNameResolverFactory`.
When the authority has not been set, SmartNameResolverFactory will be initialized with an empty string authority.
```Java
// io.etcd.jetcd.ClientConnectionManager
channelBuilder.nameResolverFactory(
forEndpoints(
Util.supplyIfNull(builder.authority(), () -> ""),
builder.endpoints(),
Util.supplyIfNull(builder.uriResolverLoader(),
URIResolverLoader::defaultLoader)));
```
\>\> @beiwangnull
you can set the value of authority explicitly to avoid the bug for now.
```Kotlin
val client = Client.builder()
.sslContext(context)
.endpoints("http://server-host:2712")
.authority("etcd") // Must be a SAN in server cert if <server-host> is not in cert
.build()
```
Reference: etcd-io/jetcd#55, etcd-io/jetcd#652, grpc/grpc-java#2662
\>\> @wu-sheng
We need to discuss how we do if we can't get authority from `ManagedChannel`, the name resolver could override the original value of authority.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675789563
@devkanro Could you take a look on this? Include my comment about the `injection` not working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675450517
@ascrutae I think there are strange codes here.
https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/client/TracingClientCall.java#L73L84
Why the codes do `inject` before the `context#item#put`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-687627131
I don't have time to read the gRPC source codes as you did/are doing. I could only say, this peer should map to the target instance. No matter as logic name or real network address. Feel free to use any method you need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] francis177 commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
francis177 commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683535931
@wu-sheng I'm fixing the same problem with @beiwangnull. Main service access etcd cluster via jetcd, with mTLS enabled. Also using skywalking.
@devkanro before asking, I've verified setting any one of domains in the cert works fine. What if etcd node with the authority domain goes down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] beiwangnull edited a comment on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
beiwangnull edited a comment on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-678969445
@devkanro
client and server use TLS
Im use jetcd，connect etcd use by GRPC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675810204
@wu-sheng sure assign to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] beiwangnull commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
beiwangnull commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-678969445
client and server use TLS
Im use jetcd，connect etcd use by GRPC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5349:
URL: https://github.com/apache/skywalking/issues/5349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro edited a comment on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro edited a comment on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683591854
@francis177
I think it will work fine, the value of authority just used for auth. Actually, the client will not connect to authority if you don't set it in endpoints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-683591854
@francis177
I think it will work fine, the value of authority just used for auth. Actually, the client will not connect to it if you don't set it in endpoints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] devkanro commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
devkanro commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-685321380
@francis177
Yes, If you have endpoints with 'etcd1, etcd2, etcd3', and set authority to 'etcd'.
The client will connect to 'etcd1, etcd2, etcd3' not the 'etcd'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675450517
@ascrutae I think there are strange codes here.
https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/client/TracingClientCall.java#L73-L84
Why the codes do `inject` before the `context#item#put`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-675448920
What is SkyWalking 8.0.2? We don't have that release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5349: plugin GRPC not support TLS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5349:
URL: https://github.com/apache/skywalking/issues/5349#issuecomment-680401118
@devkanro We just need the remote name or network address. I think we could get that from the stub initialization, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org